DM-40287: Package cleanups #16

timj · 2024-01-03T22:12:55Z

Fix location of SqlRegistry
Add numpydoc and ruff fixes
Switch to pyproject.toml
Fix mypy
Update dependencies

They have sphgeom references.

The package has not required pydantic itself for a long time, although the mypy file is configured to assume that pydantic is available for validation due to daf_butler classes.

codecov-commenter · 2024-01-03T22:16:19Z

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (df68d65) 97.87% compared to head (6bf4ba9) 62.07%.

Files	Patch %	Lines
...on/lsst/dax/obscore/script/obscore_update_table.py	25.00%	3 Missing ⚠️
python/lsst/dax/obscore/script/obscore_export.py	33.33%	2 Missing ⚠️
...dax/obscore/script/obscore_set_exposure_regions.py	0.00%	2 Missing ⚠️
tests/test_import.py	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
- Coverage   97.87%   62.07%   -35.80%     
===========================================
  Files           1       11       +10     
  Lines          94      472      +378     
  Branches        9      108       +99     
===========================================
+ Hits           92      293      +201     
- Misses          1      169      +168     
- Partials        1       10        +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andy-slac

Thanks for all fixes! Looks great, a couple of minor comments.

.github/workflows/docstyle.yaml

python/lsst/dax/obscore/obscore_exporter.py

3.10 no longer works with daf_butler

and don't check dependencies when pip installing

We do not have any script tests at this time.

timj added 13 commits January 3, 2024 13:58

Uprev pre-commit

b1df2bc

Update config to declare python 3.11

7f316b5

Use new location for SqlRegistry

5eead26

Fix spacing for black compliance

701f0f8

Remove --- from start of yaml file

f6aaa04

Declare that yaml files can be unsafe

45ab980

They have sphgeom references.

Docstring fixes from ruff

ec8b840

Add ruff to pre-commit

25abbb4

Modernize type annotations

8a3da9a

Add ruff configuration

d6fc62f

Fix some mypy problems

4359512

Remove explicit pydantic dependency

7af6fd2

The package has not required pydantic itself for a long time, although the mypy file is configured to assume that pydantic is available for validation due to daf_butler classes.

Fix numpydoc string with velin

0a48581

timj force-pushed the tickets/DM-40287 branch from f29fd48 to c0481f4 Compare January 3, 2024 22:16

timj requested a review from andy-slac January 3, 2024 22:24

timj force-pushed the tickets/DM-40287 branch 2 times, most recently from da7105a to 0d1ef89 Compare January 3, 2024 22:58

andy-slac approved these changes Jan 8, 2024

View reviewed changes

.github/workflows/docstyle.yaml Outdated Show resolved Hide resolved

python/lsst/dax/obscore/obscore_exporter.py Outdated Show resolved Hide resolved

timj added 3 commits January 8, 2024 12:26

Fix numpydoc strings

6e4e4ef

Add numpydoc configuration

af54b87

Add pydocstyle configuration

ef37a19

timj force-pushed the tickets/DM-40287 branch from f658d39 to fd9a7b9 Compare January 8, 2024 19:27

timj added 7 commits January 8, 2024 12:28

Add document style check action

0b6ef5a

Uprev packages for github actions

d8f3a8e

3.10 no longer works with daf_butler

Fix some of the doc build problems

1ecf265

Migrate to pyproject.toml

8ae49b2

Use dataId.mapping instead of deprecated .full

175667b

Stop using pytest-flake8 in action

b715d65

and don't check dependencies when pip installing

Use correct class name in coverage report in action

96b5d75

timj added 4 commits January 8, 2024 12:28

Add ruff github action

751ec36

Add simple test force loading of script code

698349a

We do not have any script tests at this time.

Add numpydoc pre-commit

1d97efb

Replace a parse_obj with a model_validate for pydantic v2

e5980ec

timj force-pushed the tickets/DM-40287 branch from fd9a7b9 to e5980ec Compare January 8, 2024 19:28

timj and others added 3 commits January 8, 2024 12:31

Remove daf_relation from dependencies

ba57abd

Explicitly add utils to dependencies

0da2d2a

Update SqlQueryBackend construction to reflect DM-42324 changes.

6bf4ba9

timj merged commit b8c2b4b into main Jan 8, 2024
11 of 13 checks passed

timj deleted the tickets/DM-40287 branch January 8, 2024 21:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DM-40287: Package cleanups #16

DM-40287: Package cleanups #16

timj commented Jan 3, 2024

codecov-commenter commented Jan 3, 2024 •

edited by codecov bot

Loading

andy-slac left a comment

DM-40287: Package cleanups #16

DM-40287: Package cleanups #16

Conversation

timj commented Jan 3, 2024

codecov-commenter commented Jan 3, 2024 • edited by codecov bot Loading

Codecov Report

andy-slac left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 3, 2024 •

edited by codecov bot

Loading