Skip to content

Commit

Permalink
Update JavaScript dependencies and install method
Browse files Browse the repository at this point in the history
JavaScript apparently now needs to be installed with `--force`
instead of `--legacy-peer-deps` or some dependencies aren't
correctly installed. Change the `Makefile` and GitHub Actions
configuration accordingly.

Bump the version of Node and update frozen JavaScript dependencies.
  • Loading branch information
rra committed Dec 18, 2024
1 parent 31c476f commit cabfb84
Show file tree
Hide file tree
Showing 4 changed files with 656 additions and 392 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
# --legacy-peer-deps is currently required because react-aria-modal
# hasn't been updated for the latest React.
- name: Install Node dependencies
run: npm ci --legacy-peer-deps
run: npm ci --force
if: steps.node-cache.outputs.cache-hit != 'true'
working-directory: ./ui

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.15.1
20.18.1
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ init:
rm -rf .tox
uv pip install --upgrade pre-commit
pre-commit install
cd ui && npm install --legacy-peer-deps
cd ui && npm install --force

# This is defined as a Makefile target instead of only a tox command because
# if the command fails we want to cat output.txt, which contains the
Expand Down
Loading

0 comments on commit cabfb84

Please sign in to comment.