VLAD Improvements (openMVG#1964)

* [Build] install rules for VLAD binary * [VLAD] Use codebook size as method parameter. - this fix a bug where changing codebook size parameter in VLAD command-line results in inconsistent values
lt-xiang · Nov 19, 2021 · 8f61623 · 8f61623
1 parent 6ebb155
commit 8f61623
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/software/SfM/CMakeLists.txt b/src/software/SfM/CMakeLists.txt
@@ -148,13 +148,15 @@ target_link_libraries(openMVG_main_MatchesToTracks
 set_property( TARGET openMVG_main_ListMatchingPairs PROPERTY FOLDER OpenMVG/software )
 set_property( TARGET openMVG_main_ComputeFeatures   PROPERTY FOLDER OpenMVG/software )
 set_property( TARGET openMVG_main_PairGenerator     PROPERTY FOLDER OpenMVG/software )
+set_property( TARGET openMVG_main_ComputeVLAD       PROPERTY FOLDER OpenMVG/software )
 set_property( TARGET openMVG_main_ComputeMatches    PROPERTY FOLDER OpenMVG/software )
 set_property( TARGET openMVG_main_GeometricFilter   PROPERTY FOLDER OpenMVG/software )
 set_property( TARGET openMVG_main_MatchesToTracks   PROPERTY FOLDER OpenMVG/software )
 
 install( TARGETS openMVG_main_ListMatchingPairs DESTINATION bin/ )
 install( TARGETS openMVG_main_ComputeFeatures   DESTINATION bin/ )
 install( TARGETS openMVG_main_PairGenerator     DESTINATION bin/ )
+install( TARGETS openMVG_main_ComputeVLAD       DESTINATION bin/ )
 install( TARGETS openMVG_main_ComputeMatches    DESTINATION bin/ )
 install( TARGETS openMVG_main_GeometricFilter   DESTINATION bin/ )
 install( TARGETS openMVG_main_MatchesToTracks   DESTINATION bin/ )

diff --git a/src/software/SfM/main_ComputeVLAD.cpp b/src/software/SfM/main_ComputeVLAD.cpp
@@ -333,7 +333,7 @@ int main(int argc, char **argv) {
           << std::endl;
 
   VLADBase::DescriptorVector codebook;
-  codebook = vlad_builder->BuildCodebook(descriptor_array);
+  codebook = vlad_builder->BuildCodebook(descriptor_array, codebook_size);
 
   // Freeing some memory
   descriptor_array.clear();