Add ARC support checks to the entire codebase.

It appears that people have been adding Nimbus to non-ARC projects and experiencing memory leaks.
lts1610 · Jul 24, 2012 · 4134612 · 4134612
1 parent 2abe9f5
commit 4134612
Show file tree

Hide file tree

Showing 72 changed files with 266 additions and 12 deletions.
diff --git a/src/attributedlabel/src/NIAttributedLabel.m b/src/attributedlabel/src/NIAttributedLabel.m
@@ -20,6 +20,10 @@
 #import "NSMutableAttributedString+NimbusAttributedLabel.h"
 #import <QuartzCore/QuartzCore.h>
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 static const CGFloat kVMargin = 5.0f;
 static const NSTimeInterval kLongPressTimeInterval = 0.5;
 static const CGFloat kLongPressGutter = 22;

diff --git a/src/attributedlabel/src/NSMutableAttributedString+NimbusAttributedLabel.m b/src/attributedlabel/src/NSMutableAttributedString+NimbusAttributedLabel.m
@@ -18,6 +18,10 @@
 
 #import "NimbusCore.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 NI_FIX_CATEGORY_BUG(NSAttributedStringNimbusAttributedLabel)
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/badge/src/NIBadgeView.m b/src/badge/src/NIBadgeView.m
@@ -18,6 +18,10 @@
 
 #import "NimbusCore.h" // For NIScreenScale
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 static const CGFloat kMinimumWidth = 30.f;
 static const CGFloat kHorizontalMargins = 20.f;
 static const CGFloat kVerticalMargins = 10.f;

diff --git a/src/core/src/NICommonMetrics.m b/src/core/src/NICommonMetrics.m
@@ -18,6 +18,9 @@
 
 #import "NISDKAvailability.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 CGFloat NIToolbarHeightForOrientation(UIInterfaceOrientation orientation) {

diff --git a/src/core/src/NIDataStructures.m b/src/core/src/NIDataStructures.m
@@ -19,6 +19,10 @@
 #import "NIDebuggingTools.h"
 #import "NIPreprocessorMacros.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 // The internal representation of a single node.
 @interface NILinkedListNode : NSObject
 @property (nonatomic, readwrite, retain) id object;

diff --git a/src/core/src/NIDebuggingTools.m b/src/core/src/NIDebuggingTools.m
@@ -17,6 +17,10 @@
 
 #import "NIDebuggingTools.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 NSInteger NIMaxLogLevel = NILOGLEVEL_WARNING;
 BOOL NIDebugAssertionsShouldBreak = YES;
 

diff --git a/src/core/src/NIDeviceOrientation.m b/src/core/src/NIDeviceOrientation.m
@@ -23,6 +23,9 @@
 #import "NIDebuggingTools.h"
 #import "NISDKAvailability.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 BOOL NIIsSupportedOrientation(UIInterfaceOrientation orientation) {

diff --git a/src/core/src/NIError.m b/src/core/src/NIError.m
@@ -16,6 +16,9 @@
 
 #import "NIError.h"
 
-NSString* const NINimbusErrorDomain = @"com.nimbus.error";
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
+NSString* const NINimbusErrorDomain = @"com.nimbus.error";
 NSString* const NIImageErrorKey = @"image";
diff --git a/src/core/src/NIFoundationMethods.m b/src/core/src/NIFoundationMethods.m
@@ -18,6 +18,9 @@
 
 #import "NIDebuggingTools.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/core/src/NIInMemoryCache.m b/src/core/src/NIInMemoryCache.m
@@ -22,6 +22,10 @@
 
 #import <UIKit/UIKit.h>
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 @interface NIMemoryCache()
 // Mapping from a name (usually a URL) to an internal object.
 @property (nonatomic, readwrite, retain) NSMutableDictionary* cacheMap;

diff --git a/src/core/src/NINavigationAppearance.m b/src/core/src/NINavigationAppearance.m
@@ -18,6 +18,10 @@
 #import "NIDebuggingTools.h"
 #import "NISDKAvailability.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 static NSMutableArray* sAppearanceStack = nil;
 
 /**

diff --git a/src/core/src/NINetworkActivity.m b/src/core/src/NINetworkActivity.m
@@ -25,6 +25,10 @@
 #import <pthread.h>
 #import <UIKit/UIKit.h>
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 static int              gNetworkTaskCount = 0;
 static pthread_mutex_t  gMutex = PTHREAD_MUTEX_INITIALIZER;
 static const NSTimeInterval kDelayBeforeDisablingActivity = 0.1;

diff --git a/src/core/src/NINonEmptyCollectionTesting.m b/src/core/src/NINonEmptyCollectionTesting.m
@@ -18,6 +18,9 @@
 
 #import "NINonEmptyCollectionTesting.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 BOOL NIIsArrayWithObjects(id object) {

diff --git a/src/core/src/NINonRetainingCollections.m b/src/core/src/NINonRetainingCollections.m
@@ -18,6 +18,9 @@
 
 #import "NINonRetainingCollections.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 NSMutableArray* NICreateNonRetainingMutableArray(void) {

diff --git a/src/core/src/NIOperations.m b/src/core/src/NIOperations.m
@@ -20,6 +20,9 @@
 #import "NIPreprocessorMacros.h"
 #import "NIOperations+Subclassing.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/core/src/NIPaths.m b/src/core/src/NIPaths.m
@@ -18,6 +18,9 @@
 
 #import "NIPaths.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 NSString* NIPathForBundleResource(NSBundle* bundle, NSString* relativePath) {

diff --git a/src/core/src/NIRuntimeClassModifications.m b/src/core/src/NIRuntimeClassModifications.m
@@ -20,6 +20,9 @@
 
 #import <objc/runtime.h>
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 void NISwapInstanceMethods(Class cls, SEL originalSel, SEL newSel) {

diff --git a/src/core/src/NISDKAvailability.m b/src/core/src/NISDKAvailability.m
@@ -18,6 +18,9 @@
 
 #import "NimbusCore.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 BOOL NIIsPad(void) {

diff --git a/src/core/src/NIState.m b/src/core/src/NIState.m
@@ -18,6 +18,10 @@
 
 #import "NIInMemoryCache.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 static NIImageMemoryCache* sNimbusGlobalMemoryCache = nil;
 static NSOperationQueue* sNimbusGlobalOperationQueue = nil;
 

diff --git a/src/core/src/NIViewRecycler.m b/src/core/src/NIViewRecycler.m
@@ -18,6 +18,10 @@
 
 #import "NimbusCore.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 @interface NIViewRecycler()
 @property (nonatomic, readwrite, retain) NSMutableDictionary* reuseIdentifiersToRecycledViews;
 @end

diff --git a/src/core/src/NSData+NimbusCore.m b/src/core/src/NSData+NimbusCore.m
@@ -22,6 +22,9 @@
 
 #import <CommonCrypto/CommonDigest.h>
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/core/src/NSString+NimbusCore.m b/src/core/src/NSString+NimbusCore.m
@@ -23,6 +23,9 @@
 
 #import <UIKit/UIKit.h>
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/core/src/UIView+NimbusCore.m b/src/core/src/UIView+NimbusCore.m
@@ -20,6 +20,9 @@
 
 #import "NIPreprocessorMacros.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/css/src/CSSTokens.m b/src/css/src/CSSTokens.m
@@ -14,6 +14,10 @@
 // limitations under the License.
 //
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 const char* cssnames[] = {
   "STRING",
   "IDENT",

diff --git a/src/css/src/NICSSParser.m b/src/css/src/NICSSParser.m
@@ -21,6 +21,10 @@
 
 #import <pthread.h>
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 static pthread_mutex_t gMutex = PTHREAD_MUTEX_INITIALIZER;
 NSString* const kPropertyOrderKey = @"__kRuleSetOrder__";
 NSString* const kDependenciesSelectorKey = @"__kDependencies__";

diff --git a/src/css/src/NICSSRuleset.m b/src/css/src/NICSSRuleset.m
@@ -19,6 +19,10 @@
 #import "NICSSParser.h"
 #import "NimbusCore.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 static NSString* const kTextColorKey = @"color";
 static NSString* const kTextAlignmentKey = @"text-align";
 static NSString* const kFontKey = @"font";

diff --git a/src/css/src/NIChameleonObserver.m b/src/css/src/NIChameleonObserver.m
@@ -21,6 +21,10 @@
 #import "NimbusCore+Additions.h"
 #import "AFNetworking.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 static NSString* const kWatchFilenameKey = @"___watch___";
 static const NSTimeInterval kTimeoutInterval = 1000;
 static const NSInteger kMaxNumberOfRetries = 3;

diff --git a/src/css/src/NIDOM.m b/src/css/src/NIDOM.m
@@ -19,6 +19,9 @@
 #import "NIStylesheet.h"
 #import "NimbusCore.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/css/src/NIStylesheet.m b/src/css/src/NIStylesheet.m
@@ -21,6 +21,10 @@
 #import "NIStyleable.h"
 #import "NimbusCore.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
+
 NSString* const NIStylesheetDidChangeNotification = @"NIStylesheetDidChangeNotification";
 
 @interface NIStylesheet()

diff --git a/src/css/src/NIStylesheetCache.m b/src/css/src/NIStylesheetCache.m
@@ -19,6 +19,9 @@
 #import "NIStylesheet.h"
 #import "NimbusCore.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/css/src/UIActivityIndicatorView+NIStyleable.m b/src/css/src/UIActivityIndicatorView+NIStyleable.m
@@ -20,8 +20,11 @@
 #import "NICSSRuleset.h"
 #import "NimbusCore.h"
 
-NI_FIX_CATEGORY_BUG(UIActivityIndicatorView_NIStyleable)
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
+NI_FIX_CATEGORY_BUG(UIActivityIndicatorView_NIStyleable)
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/css/src/UIButton+NIStyleable.m b/src/css/src/UIButton+NIStyleable.m
@@ -20,8 +20,11 @@
 #import "NICSSRuleset.h"
 #import "NimbusCore.h"
 
-NI_FIX_CATEGORY_BUG(UIButton_NIStyleable)
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
+NI_FIX_CATEGORY_BUG(UIButton_NIStyleable)
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/css/src/UILabel+NIStyleable.m b/src/css/src/UILabel+NIStyleable.m
@@ -20,8 +20,11 @@
 #import "NICSSRuleset.h"
 #import "NimbusCore.h"
 
-NI_FIX_CATEGORY_BUG(UILabel_NIStyleable)
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
+NI_FIX_CATEGORY_BUG(UILabel_NIStyleable)
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/css/src/UINavigationBar+NIStyleable.m b/src/css/src/UINavigationBar+NIStyleable.m
@@ -20,8 +20,11 @@
 #import "NICSSRuleset.h"
 #import "NimbusCore.h"
 
-NI_FIX_CATEGORY_BUG(UINavigationBar_NIStyleable)
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
+NI_FIX_CATEGORY_BUG(UINavigationBar_NIStyleable)
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/css/src/UIScrollView+NIStyleable.m b/src/css/src/UIScrollView+NIStyleable.m
@@ -20,8 +20,11 @@
 #import "NICSSRuleset.h"
 #import "NimbusCore.h"
 
-NI_FIX_CATEGORY_BUG(UIScrollView_NIStyleable)
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
+NI_FIX_CATEGORY_BUG(UIScrollView_NIStyleable)
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/css/src/UISearchBar+NIStyleable.m b/src/css/src/UISearchBar+NIStyleable.m
@@ -20,8 +20,11 @@
 #import "NICSSRuleset.h"
 #import "NimbusCore.h"
 
-NI_FIX_CATEGORY_BUG(UISearchBar_NIStyleable)
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "Nimbus requires ARC support."
+#endif
 
+NI_FIX_CATEGORY_BUG(UISearchBar_NIStyleable)
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////////////////////////