Skip to content

Commit

Permalink
net: mvneta: Remove superfluous SMP function call
Browse files Browse the repository at this point in the history
Since commit 3b9d6da ("cpu/hotplug: Fix rollback during error-out
in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.

Replace smp_call_function_single() with a direct call to
mvneta_percpu_enable() or mvneta_percpu_disable(). The functions do
not require to be called with interrupts disabled, therefore the
smp_call_function_single() calling convention is not preserved.

Cc: Thomas Petazzoni <[email protected]>
Cc: [email protected]
Signed-off-by: Anna-Maria Gleixner <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
anna-marialx authored and davem330 committed May 3, 2016
1 parent ce24c2b commit 0e28bf9
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/ethernet/marvell/mvneta.c
Original file line number Diff line number Diff line change
Expand Up @@ -3354,8 +3354,7 @@ static int mvneta_percpu_notifier(struct notifier_block *nfb,
/* Enable per-CPU interrupts on the CPU that is
* brought up.
*/
smp_call_function_single(cpu, mvneta_percpu_enable,
pp, true);
mvneta_percpu_enable(pp);

/* Enable per-CPU interrupt on the one CPU we care
* about.
Expand Down Expand Up @@ -3387,8 +3386,7 @@ static int mvneta_percpu_notifier(struct notifier_block *nfb,
/* Disable per-CPU interrupts on the CPU that is
* brought down.
*/
smp_call_function_single(cpu, mvneta_percpu_disable,
pp, true);
mvneta_percpu_disable(pp);

break;
case CPU_DEAD:
Expand Down

0 comments on commit 0e28bf9

Please sign in to comment.