Skip to content

Commit

Permalink
PM / Domains: Allow genpd to power on during system PM phases
Browse files Browse the repository at this point in the history 
If a PM domain is powered off when the first device starts its system PM
prepare phase, genpd prevents any further attempts to power on the PM
domain during the following system PM phases. Not until the system PM
complete phase is finalized for all devices in the PM domain, genpd again
allows it to be powered on.

This behaviour needs to be changed, as a subsystem/driver for a device in
the same PM domain may still need to be able to serve requests in some of
the system PM phases. Accordingly, it may need to runtime resume its
device and thus also request the corresponding PM domain to be powered on.

To deal with these scenarios, let's make the device operational in the
system PM prepare phase by runtime resuming it, no matter if the PM domain
is powered on or off. Changing this also enables us to remove genpd's
suspend_power_off flag, as it's being used to track this condition.
Additionally, we must allow the PM domain to be powered on via runtime PM
during the system PM phases.

This change also requires a fix in the AMD ACP (Audio CoProcessor) drm
driver. It registers a genpd to model the ACP as a PM domain, but
unfortunately it's also abuses genpd's "internal" suspend_power_off flag
to deal with a corner case at system PM resume.

More precisely, the so called SMU block powers on the ACP at system PM
resume, unconditionally if it's being used or not. This may lead to that
genpd's internal status of the power state, may not correctly reflect the
power state of the HW after a system PM resume.

Because of changing the behaviour of genpd, by runtime resuming devices in
the prepare phase, the AMD ACP drm driver no longer have to deal with this
corner case. So let's just drop the related code in this driver.

Signed-off-by: Ulf Hansson <[email protected]>
Reviewed-by: Kevin Hilman <[email protected]>
Acked-by: Maruthi Bayyavarapu <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
  • Loading branch information
@storulf @rafaeljw
storulf authored and rafaeljw committed Jun 16, 2016
1 parent 5edb564 commit 39dd0f2
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 77 deletions.
84 changes: 31 additions & 53 deletions drivers/base/power/domain.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,7 @@ static int genpd_poweron(struct generic_pm_domain *genpd, unsigned int depth)
struct gpd_link *link;
int ret = 0;

if (genpd->status == GPD_STATE_ACTIVE
|| (genpd->prepared_count > 0 && genpd->suspend_power_off))
if (genpd->status == GPD_STATE_ACTIVE)
return 0;

/*
Expand Down Expand Up @@ -735,21 +734,22 @@ static int pm_genpd_prepare(struct device *dev)

mutex_lock(&genpd->lock);

if (genpd->prepared_count++ == 0) {
if (genpd->prepared_count++ == 0)
genpd->suspended_count = 0;
genpd->suspend_power_off = genpd->status == GPD_STATE_POWER_OFF;
}

mutex_unlock(&genpd->lock);

if (genpd->suspend_power_off)
return 0;

/*
* The PM domain must be in the GPD_STATE_ACTIVE state at this point,
* so genpd_poweron() will return immediately, but if the device
* is suspended (e.g. it's been stopped by genpd_stop_dev()), we need
* to make it operational.
* Even if the PM domain is powered off at this point, we can't expect
* it to remain in that state during the entire system PM suspend
* phase. Any subsystem/driver for a device in the PM domain, may still
* need to serve a request which may require the device to be runtime
* resumed and its PM domain to be powered.
*
* As we are disabling runtime PM at this point, we are preventing the
* subsystem/driver to decide themselves. For that reason, we need to
* make sure the device is operational as it may be required in some
* cases.
*/
pm_runtime_resume(dev);
__pm_runtime_disable(dev, false);
Expand All @@ -758,8 +758,7 @@ static int pm_genpd_prepare(struct device *dev)
if (ret) {
mutex_lock(&genpd->lock);

if (--genpd->prepared_count == 0)
genpd->suspend_power_off = false;
genpd->prepared_count--;

mutex_unlock(&genpd->lock);
pm_runtime_enable(dev);
Expand All @@ -786,7 +785,7 @@ static int pm_genpd_suspend(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : pm_generic_suspend(dev);
return pm_generic_suspend(dev);
}

/**
Expand All @@ -807,7 +806,7 @@ static int pm_genpd_suspend_late(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : pm_generic_suspend_late(dev);
return pm_generic_suspend_late(dev);
}

/**
Expand All @@ -827,8 +826,7 @@ static int pm_genpd_suspend_noirq(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

if (genpd->suspend_power_off
|| (dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev)))
if (dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
return 0;

genpd_stop_dev(genpd, dev);
Expand Down Expand Up @@ -860,8 +858,7 @@ static int pm_genpd_resume_noirq(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

if (genpd->suspend_power_off
|| (dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev)))
if (dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
return 0;

/*
Expand Down Expand Up @@ -894,7 +891,7 @@ static int pm_genpd_resume_early(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : pm_generic_resume_early(dev);
return pm_generic_resume_early(dev);
}

/**
Expand All @@ -915,7 +912,7 @@ static int pm_genpd_resume(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : pm_generic_resume(dev);
return pm_generic_resume(dev);
}

/**
Expand All @@ -936,7 +933,7 @@ static int pm_genpd_freeze(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : pm_generic_freeze(dev);
return pm_generic_freeze(dev);
}

/**
Expand All @@ -958,7 +955,7 @@ static int pm_genpd_freeze_late(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : pm_generic_freeze_late(dev);
return pm_generic_freeze_late(dev);
}

/**
Expand All @@ -980,7 +977,7 @@ static int pm_genpd_freeze_noirq(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : genpd_stop_dev(genpd, dev);
return genpd_stop_dev(genpd, dev);
}

/**
Expand All @@ -1000,8 +997,7 @@ static int pm_genpd_thaw_noirq(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ?
0 : genpd_start_dev(genpd, dev);
return genpd_start_dev(genpd, dev);
}

/**
Expand All @@ -1023,7 +1019,7 @@ static int pm_genpd_thaw_early(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : pm_generic_thaw_early(dev);
return pm_generic_thaw_early(dev);
}

/**
Expand All @@ -1044,7 +1040,7 @@ static int pm_genpd_thaw(struct device *dev)
if (IS_ERR(genpd))
return -EINVAL;

return genpd->suspend_power_off ? 0 : pm_generic_thaw(dev);
return pm_generic_thaw(dev);
}

/**
Expand Down Expand Up @@ -1072,26 +1068,13 @@ static int pm_genpd_restore_noirq(struct device *dev)
* At this point suspended_count == 0 means we are being run for the
* first time for the given domain in the present cycle.
*/
if (genpd->suspended_count++ == 0) {
if (genpd->suspended_count++ == 0)
/*
* The boot kernel might put the domain into arbitrary state,
* so make it appear as powered off to pm_genpd_sync_poweron(),
* so that it tries to power it on in case it was really off.
*/
genpd->status = GPD_STATE_POWER_OFF;
if (genpd->suspend_power_off) {
/*
* If the domain was off before the hibernation, make
* sure it will be off going forward.
*/
genpd_power_off(genpd, true);

return 0;
}
}

if (genpd->suspend_power_off)
return 0;

pm_genpd_sync_poweron(genpd, true);

Expand All @@ -1110,7 +1093,6 @@ static int pm_genpd_restore_noirq(struct device *dev)
static void pm_genpd_complete(struct device *dev)
{
struct generic_pm_domain *genpd;
bool run_complete;

dev_dbg(dev, "%s()\n", __func__);

Expand All @@ -1120,18 +1102,14 @@ static void pm_genpd_complete(struct device *dev)

mutex_lock(&genpd->lock);

run_complete = !genpd->suspend_power_off;
if (--genpd->prepared_count == 0)
genpd->suspend_power_off = false;
genpd->prepared_count--;

mutex_unlock(&genpd->lock);

if (run_complete) {
pm_generic_complete(dev);
pm_runtime_set_active(dev);
pm_runtime_enable(dev);
pm_request_idle(dev);
}
pm_generic_complete(dev);
pm_runtime_set_active(dev);
pm_runtime_enable(dev);
pm_request_idle(dev);
}

/**
Expand Down
23 changes: 0 additions & 23 deletions drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -421,29 +421,6 @@ static int acp_suspend(void *handle)

static int acp_resume(void *handle)
{
int i, ret;
struct acp_pm_domain *apd;
struct amdgpu_device *adev = (struct amdgpu_device *)handle;

/* return early if no ACP */
if (!adev->acp.acp_genpd)
return 0;

/* SMU block will power on ACP irrespective of ACP runtime status.
* Power off explicitly based on genpd ACP runtime status so that ACP
* hw and ACP-genpd status are in sync.
* 'suspend_power_off' represents "Power status before system suspend"
*/
if (adev->acp.acp_genpd->gpd.suspend_power_off == true) {
apd = container_of(&adev->acp.acp_genpd->gpd,
struct acp_pm_domain, gpd);

for (i = 4; i >= 0 ; i--) {
ret = acp_suspend_tile(apd->cgs_dev, ACP_TILE_P1 + i);
if (ret)
pr_err("ACP tile %d tile suspend failed\n", i);
}
}
return 0;
}

Expand Down
1 change: 0 additions & 1 deletion include/linux/pm_domain.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ struct generic_pm_domain {
unsigned int device_count; /* Number of devices */
unsigned int suspended_count; /* System suspend device counter */
unsigned int prepared_count; /* Suspend counter of prepared devices */
bool suspend_power_off; /* Power status before system suspend */
int (*power_off)(struct generic_pm_domain *domain);
int (*power_on)(struct generic_pm_domain *domain);
struct gpd_dev_ops dev_ops;
Expand Down

0 comments on commit 39dd0f2

Please sign in to comment.