Skip to content

Commit

Permalink
memory: tegra: mc: Add missing of_node_put()
Browse files Browse the repository at this point in the history
for_each_child_of_node() performs an of_node_get() on each iteration, so
to break out of the loop an of_node_put() is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

 for_each_child_of_node(..., n) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <[email protected]>
Signed-off-by: Thierry Reding <[email protected]>
  • Loading branch information
musicakc authored and thierryreding committed Jun 14, 2016
1 parent d1122e4 commit 55bb1d8
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/memory/tegra/mc.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,10 @@ static int load_timings(struct tegra_mc *mc, struct device_node *node)
timing = &mc->timings[i++];

err = load_one_timing(mc, timing, child);
if (err)
if (err) {
of_node_put(child);
return err;
}
}

return 0;
Expand All @@ -210,9 +212,9 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc)
continue;

err = load_timings(mc, node);
of_node_put(node);
if (err)
return err;
of_node_put(node);
break;
}

Expand Down

0 comments on commit 55bb1d8

Please sign in to comment.