ALSA: line6: fix a crash in line6_hwdep_write()

The error checking here is messed up so we could end up dereferencing -EFAULT. Fixes: a16039c ('ALSA: line6: Add hwdep interface to access the POD control messages') Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Takashi Sakamoto <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
lucamilanesio · Oct 12, 2016 · fdd8218 · fdd8218
1 parent 30c0702
commit fdd8218
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
@@ -604,8 +604,8 @@ line6_hwdep_write(struct snd_hwdep *hwdep, const char __user *data, long count,
 	}
 
 	data_copy = memdup_user(data, count);
-	if (IS_ERR(ERR_PTR))
-		return -ENOMEM;
+	if (IS_ERR(data_copy))
+		return PTR_ERR(data_copy);
 
 	rv = line6_send_raw_message(line6, data_copy, count);