Skip to content

Commit

Permalink
in_merge_bases(): use paint_down_to_common()
Browse files Browse the repository at this point in the history
With paint_down_to_common(), we can tell if "commit" is reachable
from "reference" by simply looking at its object flag, instead of
iterating over the merge bases.

Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
gitster committed Aug 31, 2012
1 parent da1f515 commit 6440fdb
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -786,20 +786,17 @@ int is_descendant_of(struct commit *commit, struct commit_list *with_commit)
*/
int in_merge_bases(struct commit *commit, struct commit *reference)
{
struct commit_list *bases, *b;
struct commit_list *bases;
int ret = 0;

bases = merge_bases_many(commit, 1, &reference);
if (parse_commit(commit) || parse_commit(reference))
return ret;

bases = paint_down_to_common(commit, 1, &reference);
if (commit->object.flags & PARENT2)
ret = 1;
clear_commit_marks(commit, all_flags);
clear_commit_marks(reference, all_flags);

for (b = bases; b; b = b->next) {
if (!hashcmp(commit->object.sha1, b->item->object.sha1)) {
ret = 1;
break;
}
}

free_commit_list(bases);
return ret;
}
Expand Down

0 comments on commit 6440fdb

Please sign in to comment.