Skip to content

Commit

Permalink
Merge branch 'jc/spell-id-in-both-caps-in-message-id'
Browse files Browse the repository at this point in the history
Consistently spell "Message-ID" as such, not "Message-Id".

* jc/spell-id-in-both-caps-in-message-id:
  e-mail workflow: Message-ID is spelled with ID in both capital letters
  • Loading branch information
gitster committed Apr 11, 2023
2 parents d02343b + ba4324c commit 647a2bb
Show file tree
Hide file tree
Showing 15 changed files with 75 additions and 75 deletions.
14 changes: 7 additions & 7 deletions Documentation/MyFirstContribution.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1171,21 +1171,21 @@ between your last version and now, if it's something significant. You do not
need the exact same body in your second cover letter; focus on explaining to
reviewers the changes you've made that may not be as visible.

You will also need to go and find the Message-Id of your previous cover letter.
You will also need to go and find the Message-ID of your previous cover letter.
You can either note it when you send the first series, from the output of `git
send-email`, or you can look it up on the
https://lore.kernel.org/git[mailing list]. Find your cover letter in the
archives, click on it, then click "permalink" or "raw" to reveal the Message-Id
archives, click on it, then click "permalink" or "raw" to reveal the Message-ID
header. It should match:

----
Message-Id: <[email protected]>
Message-ID: <[email protected]>
----

Your Message-Id is `<[email protected]>`. This example will be used
below as well; make sure to replace it with the correct Message-Id for your
**previous cover letter** - that is, if you're sending v2, use the Message-Id
from v1; if you're sending v3, use the Message-Id from v2.
Your Message-ID is `<[email protected]>`. This example will be used
below as well; make sure to replace it with the correct Message-ID for your
**previous cover letter** - that is, if you're sending v2, use the Message-ID
from v1; if you're sending v3, use the Message-ID from v2.

While you're looking at the email, you should also note who is CC'd, as it's
common practice in the mailing list to keep all CCs on a thread. You can add
Expand Down
4 changes: 2 additions & 2 deletions Documentation/git-format-patch.txt
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ To omit patch numbers from the subject, use `-N`.

If given `--thread`, `git-format-patch` will generate `In-Reply-To` and
`References` headers to make the second and subsequent patch mails appear
as replies to the first mail; this also generates a `Message-Id` header to
as replies to the first mail; this also generates a `Message-ID` header to
reference.

OPTIONS
Expand Down Expand Up @@ -163,7 +163,7 @@ include::diff-options.txt[]
--no-thread::
Controls addition of `In-Reply-To` and `References` headers to
make the second and subsequent mails appear as replies to the
first. Also controls generation of the `Message-Id` header to
first. Also controls generation of the `Message-ID` header to
reference.
+
The optional <style> argument can be either `shallow` or `deep`.
Expand Down
2 changes: 1 addition & 1 deletion Documentation/git-send-email.txt
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ See the CONFIGURATION section for `sendemail.multiEdit`.

--in-reply-to=<identifier>::
Make the first mail (or all the mails with `--no-thread`) appear as a
reply to the given Message-Id, which avoids breaking threads to
reply to the given Message-ID, which avoids breaking threads to
provide a new patch series.
The second and subsequent emails will be sent as replies according to
the `--[no-]chain-reply-to` setting.
Expand Down
4 changes: 2 additions & 2 deletions git-send-email.perl
Original file line number Diff line number Diff line change
Expand Up @@ -1537,7 +1537,7 @@ sub send_message {
To: $to${ccline}
Subject: $subject
Date: $date
Message-Id: $message_id
Message-ID: $message_id
";
if ($use_xmailer) {
$header .= "X-Mailer: git-send-email $gitversion\n";
Expand Down Expand Up @@ -1832,7 +1832,7 @@ sub process_file {
$has_mime_version = 1;
push @xh, $_;
}
elsif (/^Message-Id: (.*)/i) {
elsif (/^Message-ID: (.*)/i) {
$message_id = $1;
}
elsif (/^Content-Transfer-Encoding: (.*)/i) {
Expand Down
2 changes: 1 addition & 1 deletion log-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ void log_write_email_headers(struct rev_info *opt, struct commit *commit,
fprintf(opt->diffopt.file, "From %s Mon Sep 17 00:00:00 2001\n", name);
graph_show_oneline(opt->graph);
if (opt->message_id) {
fprintf(opt->diffopt.file, "Message-Id: <%s>\n", opt->message_id);
fprintf(opt->diffopt.file, "Message-ID: <%s>\n", opt->message_id);
graph_show_oneline(opt->graph);
}
if (opt->ref_message_ids && opt->ref_message_ids->nr > 0) {
Expand Down
4 changes: 2 additions & 2 deletions mailinfo.c
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ static int check_header(struct mailinfo *mi,
ret = 1;
goto check_header_out;
}
if (parse_header(line, "Message-Id", mi, &sb)) {
if (parse_header(line, "Message-ID", mi, &sb)) {
if (mi->add_message_id)
mi->message_id = strbuf_detach(&sb, NULL);
ret = 1;
Expand Down Expand Up @@ -831,7 +831,7 @@ static int handle_commit_msg(struct mailinfo *mi, struct strbuf *line)
if (patchbreak(line)) {
if (mi->message_id)
strbuf_addf(&mi->log_message,
"Message-Id: %s\n", mi->message_id);
"Message-ID: %s\n", mi->message_id);
return 1;
}

Expand Down
56 changes: 28 additions & 28 deletions t/t4014-format-patch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -455,13 +455,13 @@ test_expect_success 'no threading' '

cat >expect.thread <<EOF
---
Message-Id: <0>
Message-ID: <0>
---
Message-Id: <1>
Message-ID: <1>
In-Reply-To: <0>
References: <0>
---
Message-Id: <2>
Message-ID: <2>
In-Reply-To: <0>
References: <0>
EOF
Expand All @@ -472,15 +472,15 @@ test_expect_success 'thread' '

cat >expect.in-reply-to <<EOF
---
Message-Id: <0>
Message-ID: <0>
In-Reply-To: <1>
References: <1>
---
Message-Id: <2>
Message-ID: <2>
In-Reply-To: <1>
References: <1>
---
Message-Id: <3>
Message-ID: <3>
In-Reply-To: <1>
References: <1>
EOF
Expand All @@ -492,17 +492,17 @@ test_expect_success 'thread in-reply-to' '

cat >expect.cover-letter <<EOF
---
Message-Id: <0>
Message-ID: <0>
---
Message-Id: <1>
Message-ID: <1>
In-Reply-To: <0>
References: <0>
---
Message-Id: <2>
Message-ID: <2>
In-Reply-To: <0>
References: <0>
---
Message-Id: <3>
Message-ID: <3>
In-Reply-To: <0>
References: <0>
EOF
Expand All @@ -513,21 +513,21 @@ test_expect_success 'thread cover-letter' '

cat >expect.cl-irt <<EOF
---
Message-Id: <0>
Message-ID: <0>
In-Reply-To: <1>
References: <1>
---
Message-Id: <2>
Message-ID: <2>
In-Reply-To: <0>
References: <1>
<0>
---
Message-Id: <3>
Message-ID: <3>
In-Reply-To: <0>
References: <1>
<0>
---
Message-Id: <4>
Message-ID: <4>
In-Reply-To: <0>
References: <1>
<0>
Expand All @@ -545,13 +545,13 @@ test_expect_success 'thread explicit shallow' '

cat >expect.deep <<EOF
---
Message-Id: <0>
Message-ID: <0>
---
Message-Id: <1>
Message-ID: <1>
In-Reply-To: <0>
References: <0>
---
Message-Id: <2>
Message-ID: <2>
In-Reply-To: <1>
References: <0>
<1>
Expand All @@ -563,16 +563,16 @@ test_expect_success 'thread deep' '

cat >expect.deep-irt <<EOF
---
Message-Id: <0>
Message-ID: <0>
In-Reply-To: <1>
References: <1>
---
Message-Id: <2>
Message-ID: <2>
In-Reply-To: <0>
References: <1>
<0>
---
Message-Id: <3>
Message-ID: <3>
In-Reply-To: <2>
References: <1>
<0>
Expand All @@ -586,18 +586,18 @@ test_expect_success 'thread deep in-reply-to' '

cat >expect.deep-cl <<EOF
---
Message-Id: <0>
Message-ID: <0>
---
Message-Id: <1>
Message-ID: <1>
In-Reply-To: <0>
References: <0>
---
Message-Id: <2>
Message-ID: <2>
In-Reply-To: <1>
References: <0>
<1>
---
Message-Id: <3>
Message-ID: <3>
In-Reply-To: <2>
References: <0>
<1>
Expand All @@ -610,22 +610,22 @@ test_expect_success 'thread deep cover-letter' '

cat >expect.deep-cl-irt <<EOF
---
Message-Id: <0>
Message-ID: <0>
In-Reply-To: <1>
References: <1>
---
Message-Id: <2>
Message-ID: <2>
In-Reply-To: <0>
References: <1>
<0>
---
Message-Id: <3>
Message-ID: <3>
In-Reply-To: <2>
References: <1>
<0>
<2>
---
Message-Id: <4>
Message-ID: <4>
In-Reply-To: <3>
References: <1>
<0>
Expand Down
8 changes: 4 additions & 4 deletions t/t4150-am.sh
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ test_expect_success setup '
git format-patch --stdout first >patch1 &&
{
echo "Message-Id: <[email protected]>" &&
echo "Message-ID: <[email protected]>" &&
echo "X-Fake-Field: Line One" &&
echo "X-Fake-Field: Line Two" &&
echo "X-Fake-Field: Line Three" &&
Expand Down Expand Up @@ -942,7 +942,7 @@ test_expect_success 'am --message-id really adds the message id' '
git am --message-id patch1.eml &&
test_path_is_missing .git/rebase-apply &&
git cat-file commit HEAD | tail -n1 >actual &&
grep Message-Id patch1.eml >expected &&
grep Message-ID patch1.eml >expected &&
test_cmp expected actual
'

Expand All @@ -954,7 +954,7 @@ test_expect_success 'am.messageid really adds the message id' '
git am patch1.eml &&
test_path_is_missing .git/rebase-apply &&
git cat-file commit HEAD | tail -n1 >actual &&
grep Message-Id patch1.eml >expected &&
grep Message-ID patch1.eml >expected &&
test_cmp expected actual
'

Expand All @@ -965,7 +965,7 @@ test_expect_success 'am --message-id -s signs off after the message id' '
git am -s --message-id patch1.eml &&
test_path_is_missing .git/rebase-apply &&
git cat-file commit HEAD | tail -n2 | head -n1 >actual &&
grep Message-Id patch1.eml >expected &&
grep Message-ID patch1.eml >expected &&
test_cmp expected actual
'

Expand Down
2 changes: 1 addition & 1 deletion t/t4258/mbox
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ From: A U Thor <[email protected]>
To: [email protected]
Subject: [PATCH v2] sample
Date: Mon, 3 Aug 2020 22:40:55 +0700
Message-Id: <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

Expand Down
2 changes: 1 addition & 1 deletion t/t5100/msg0002
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ message:

From: Nit Picker <[email protected]>
Subject: foo is too old
Message-Id: <[email protected]>
Message-ID: <[email protected]>

Hopefully this would fix the problem stated there.

Expand Down
2 changes: 1 addition & 1 deletion t/t5100/msg0003
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ message:

From: Nit Picker <[email protected]>
Subject: foo is too old
Message-Id: <[email protected]>
Message-ID: <[email protected]>

Hopefully this would fix the problem stated there.

2 changes: 1 addition & 1 deletion t/t5100/msg0012--message-id
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ docutils заменён на python-docutils
python-docutils. В то время как сам rest2web не нужен.

Signed-off-by: Dmitriy Blinov <[email protected]>
Message-Id: <[email protected]>
Message-ID: <[email protected]>
4 changes: 2 additions & 2 deletions t/t5100/quoted-cr.mbox
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ From: A U Thor <[email protected]>
To: [email protected]
Subject: [PATCH v2] sample
Date: Mon, 3 Aug 2020 22:40:55 +0700
Message-Id: <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

Expand All @@ -27,7 +27,7 @@ From: A U Thor <[email protected]>
To: [email protected]
Subject: [PATCH v2] sample
Date: Mon, 3 Aug 2020 22:40:55 +0700
Message-Id: <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

Expand Down
6 changes: 3 additions & 3 deletions t/t5100/sample.mbox
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ message:

From: Nit Picker <[email protected]>
Subject: foo is too old
Message-Id: <[email protected]>
Message-ID: <[email protected]>

Hopefully this would fix the problem stated there.

Expand Down Expand Up @@ -78,7 +78,7 @@ message:

From: Nit Picker <[email protected]>
Subject: foo is too old
Message-Id: <[email protected]>
Message-ID: <[email protected]>

Hopefully this would fix the problem stated there.

Expand Down Expand Up @@ -508,7 +508,7 @@ From [email protected] Wed Nov 12 17:54:41 2008
From: Dmitriy Blinov <[email protected]>
To: [email protected]
Date: Wed, 12 Nov 2008 17:54:41 +0300
Message-Id: <[email protected]>
Message-ID: <[email protected]>
X-Mailer: git-send-email 1.5.6.5
MIME-Version: 1.0
Content-Type: text/plain;
Expand Down
Loading

0 comments on commit 647a2bb

Please sign in to comment.