Skip to content

Commit

Permalink
replace-object: add repository argument to do_lookup_replace_object
Browse files Browse the repository at this point in the history
Add a repository argument to allow the do_lookup_replace_object caller
to be more specific about which repository to handle. This is a small
mechanical change; it doesn't change the implementation to handle
repositories other than the_repository yet.

As with the previous commits, use a macro to catch callers passing a
repository other than the_repository at compile time.

Signed-off-by: Jonathan Nieder <[email protected]>
Signed-off-by: Stefan Beller <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
stefanbeller authored and gitster committed Apr 12, 2018
1 parent fe6d34d commit 9dfe98a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions replace-object.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ struct replace_object {
* This internal function is only declared here for the benefit of
* lookup_replace_object(). Please do not call it directly.
*/
extern const struct object_id *do_lookup_replace_object(const struct object_id *oid);
#define do_lookup_replace_object(r, s) do_lookup_replace_object_##r(s)
extern const struct object_id *do_lookup_replace_object_the_repository(const struct object_id *oid);

/*
* If object sha1 should be replaced, return the replacement object's
Expand All @@ -28,7 +29,7 @@ static inline const struct object_id *lookup_replace_object(const struct object_
(the_repository->objects->replace_map &&
the_repository->objects->replace_map->map.tablesize == 0))
return oid;
return do_lookup_replace_object(oid);
return do_lookup_replace_object(the_repository, oid);
}

#endif /* REPLACE_OBJECT_H */
2 changes: 1 addition & 1 deletion replace_object.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ static void prepare_replace_object_the_repository(void)
* permanently-allocated value. This function always respects replace
* references, regardless of the value of check_replace_refs.
*/
const struct object_id *do_lookup_replace_object(const struct object_id *oid)
const struct object_id *do_lookup_replace_object_the_repository(const struct object_id *oid)
{
int depth = MAXREPLACEDEPTH;
const struct object_id *cur = oid;
Expand Down

0 comments on commit 9dfe98a

Please sign in to comment.