Skip to content

Commit

Permalink
tests: unset COLUMNS inherited from environment
Browse files Browse the repository at this point in the history
$COLUMNS must be unset to not interfere with the tests. The tests
already ignore the terminal size because output is redirected to a
file, but COLUMNS overrides terminal size detection and changes the
test output away from the standard 80.

Reported-by: Jeff King <[email protected]>
Signed-off-by: Zbigniew Jędrzejewski-Szmek <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
keszybz authored and gitster committed Mar 27, 2012
1 parent fae9d76 commit b1d645b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ EDITOR=:
# /usr/xpg4/bin/sh and /bin/ksh to bail out. So keep the unsets
# deriving from the command substitution clustered with the other
# ones.
unset VISUAL EMAIL LANGUAGE $(perl -e '
unset VISUAL EMAIL LANGUAGE COLUMNS $(perl -e '
my @env = keys %ENV;
my $ok = join("|", qw(
TRACE
Expand Down

0 comments on commit b1d645b

Please sign in to comment.