disable rules until ready to be addressed so we can have it enabled r…

…ight away
lucywheel · Jun 9, 2021 · 982b8bf · 982b8bf
1 parent 9075069
commit 982b8bf
Show file tree

Hide file tree

Showing 10 changed files with 25 additions and 12 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -5,10 +5,7 @@ module.exports = {
     es2020: true,
     node: true
   },
-  parser: '@typescript-eslint/parser',
-  plugins: [
-    '@typescript-eslint',
-  ],
+  parser: '@babel/eslint-parser',
   extends: [
     'eslint:recommended',
     'standard',
@@ -18,7 +15,7 @@ module.exports = {
     ecmaVersion: 11
   },
   rules: {
-    'import/no-extraneous-dependencies': ['error'],
+    'import/no-extraneous-dependencies': ['error']
   },
   overrides: [
     {
@@ -33,7 +30,10 @@ module.exports = {
       files: [
         '**/*.tsx'
       ],
-      plugins: ['jsx-a11y'],
+      plugins: [
+        '@typescript-eslint',
+        'jsx-a11y'
+      ],
       extends: ['plugin:jsx-a11y/recommended'],
       parser: '@typescript-eslint/parser',
       rules: {

diff --git a/components/Link.tsx b/components/Link.tsx
@@ -30,12 +30,14 @@ export function Link(props: Props) {
   if (enableNextLinks) {
     return (
       <NextLink href={href || ''} locale={locale}>
+        {/* eslint-disable-next-line jsx-a11y/anchor-has-content */}
         <a rel={isExternal ? 'noopener' : ''} {...restProps} />
       </NextLink>
     )
   }
 
   return (
+    /* eslint-disable-next-line jsx-a11y/anchor-has-content */
     <a
       href={locale ? `/${locale}${href}` : href}
       rel={isExternal ? 'noopener' : ''}

diff --git a/components/Search.tsx b/components/Search.tsx
@@ -183,6 +183,7 @@ export function Search({ isStandalone = false, updateSearchParams = true, childr
           </div>
         )}
       </div>
+      {/* eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions */}
       <div
         className={'search-overlay-desktop' + (!isStandalone && query ? ' js-open' : '')}
         onClick={closeSearch}
@@ -199,6 +200,7 @@ export function Search({ isStandalone = false, updateSearchParams = true, childr
             className={'ais-SearchBox-input' + (isStandalone || query ? ' js-open' : '')}
             type="search"
             placeholder={t`placeholder`}
+            /* eslint-disable-next-line jsx-a11y/no-autofocus */
             autoFocus={isStandalone}
             autoComplete="off"
             autoCorrect="off"

diff --git a/components/SidebarNav.tsx b/components/SidebarNav.tsx
@@ -74,10 +74,11 @@ const SidebarHomepage = () => {
           return null
         }
 
-        const href = `${!product.external ? `/${router.locale}` : ''}${product.versions?.includes(currentVersion)
-          ? `/${currentVersion}/${product.id}`
-          : product.href
-          }`
+        const href = `${!product.external ? `/${router.locale}` : ''}${
+          product.versions?.includes(currentVersion)
+            ? `/${currentVersion}/${product.id}`
+            : product.href
+        }`
 
         return (
           <li

diff --git a/components/article/ArticlePage.tsx b/components/article/ArticlePage.tsx
@@ -73,16 +73,19 @@ export const ArticlePage = () => {
                   data-default-platform={defaultPlatform || undefined}
                 >
                   <div className="UnderlineNav-body">
+                    {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
                     <a href="#" className="UnderlineNav-item platform-switcher" data-platform="mac">
                       Mac
                     </a>
+                    {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
                     <a
                       href="#"
                       className="UnderlineNav-item platform-switcher"
                       data-platform="windows"
                     >
                       Windows
                     </a>
+                    {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
                     <a
                       href="#"
                       className="UnderlineNav-item platform-switcher"

diff --git a/components/landing/CommunityExamples.tsx b/components/landing/CommunityExamples.tsx
@@ -17,7 +17,7 @@ export const CommunityExamples = () => {
   return (
     <div>
       <div className="d-flex flex-wrap gutter">
-        {productCommunityExamples.slice(0, numVisible).map((repo,) => {
+        {productCommunityExamples.slice(0, numVisible).map((repo) => {
           return (
             <div key={repo.repo} className="col-12 col-xl-4 col-lg-6 mb-4">
               <RepoCard repo={repo} />

diff --git a/components/landing/FeaturedArticles.tsx b/components/landing/FeaturedArticles.tsx
@@ -73,7 +73,7 @@ export const ArticleList = ({ title, viewAllHref, articles, maxLines = 2 }: Arti
       )}
 
       <ul className="list-style-none">
-        {articles.map((link,) => {
+        {articles.map((link) => {
           return (
             <li key={link.href} className="border-top">
               <Link

diff --git a/pages/404.tsx b/pages/404.tsx
@@ -32,11 +32,13 @@ export default function Custom404() {
           role="banner"
         >
           <Link href={`/${router.locale}`}>
+            {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
             <a className="color-text-primary" aria-hidden="true" tabIndex={-1}>
               <MarkGithubIcon size={32} />
             </a>
           </Link>
           <Link href={`/${router.locale}`}>
+            {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
             <a className="h4-mktg color-text-primary no-underline no-wrap pl-2 flex-auto">
               GitHub Docs
             </a>

diff --git a/pages/500.tsx b/pages/500.tsx
@@ -31,12 +31,14 @@ export default function Custom500() {
             role="banner"
           >
             <Link href={`/${router.locale}`}>
+              {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
               <a aria-hidden="true" tabIndex={-1}>
                 <MarkGithubIcon size={32} className="color-icon-primary" />
               </a>
             </Link>
 
             <Link href={`/${router.locale}`}>
+              {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
               <a className="h4-mktg color-text-primary no-underline no-wrap pl-2">GitHub Docs</a>
             </Link>
           </div>

diff --git a/pages/[versionId]/graphql/overview/explorer.tsx b/pages/[versionId]/graphql/overview/explorer.tsx
@@ -32,6 +32,7 @@ export default function GQLExplorer({ mainContext, graphqlExplorerUrl }: Props)
                 {airGap ? (
                   <p>GraphQL explorer is not available on this environment.</p>
                 ) : (
+                  /* eslint-disable-next-line jsx-a11y/iframe-has-title */
                   <iframe
                     id="graphiql"
                     className="graphql-explorer"