Skip to content

Commit

Permalink
Add dev-tools dependency for commons (netty#7858)
Browse files Browse the repository at this point in the history
Motivation:

We need to add a dev-tools dependecy for commons as otherwise we may fail to fetch it before we try to use it.

Modifications:

Add dependency.

Result:

Fixes netty#7842
  • Loading branch information
normanmaurer authored Apr 10, 2018
1 parent 587afdd commit 5ab8342
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,15 @@
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
</dependency>
<!-- Add dependency on dev-tools as otherwise the build will fail if not installed first manually -->
<!-- See https://github.com/netty/netty/issues/7842 -->
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-dev-tools</artifactId>
<version>${project.version}</version>
<scope>test</scope>
<optional>true</optional>
</dependency>
</dependencies>

<build>
Expand Down

0 comments on commit 5ab8342

Please sign in to comment.