Skip to content

Commit

Permalink
eventfs: Fix bitwise fields for "is_events"
Browse files Browse the repository at this point in the history
A flag was needed to denote which eventfs_inode was the "events"
directory, so a bit was taken from the "nr_entries" field, as there's not
that many entries, and 2^30 is plenty. But the bit number for nr_entries
was not updated to reflect the bit taken from it, which would add an
unnecessary integer to the structure.

Link: https://lore.kernel.org/linux-trace-kernel/[email protected]

Cc: [email protected]
Cc: Masami Hiramatsu <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Fixes: 7e8358e ("eventfs: Fix file and directory uid and gid ownership")
Signed-off-by: Steven Rostedt (Google) <[email protected]>
  • Loading branch information
rostedt committed Jan 2, 2024
1 parent ad57986 commit fd56cd5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/tracefs/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ struct eventfs_inode {
};
unsigned int is_freed:1;
unsigned int is_events:1;
unsigned int nr_entries:31;
unsigned int nr_entries:30;
};

static inline struct tracefs_inode *get_tracefs(const struct inode *inode)
Expand Down

0 comments on commit fd56cd5

Please sign in to comment.