Fix log numbber incorrect on pulsar metadata (apache#13395)

lujp · Dec 20, 2021 · 828af10 · 828af10
1 parent b261d6a
commit 828af10
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.../main/java/org/apache/pulsar/metadata/bookkeeper/LongHierarchicalLedgerRangeIterator.java b/.../main/java/org/apache/pulsar/metadata/bookkeeper/LongHierarchicalLedgerRangeIterator.java
@@ -60,7 +60,7 @@ List<String> getChildrenAt(String path) throws IOException {
             return store.getChildren(path).get();
         } catch (ExecutionException e) {
             if (log.isDebugEnabled()) {
-                log.debug("Failed to ", path);
+                log.debug("Failed to get children at {}", path);
             }
             throw new IOException(e);
         } catch (InterruptedException ie) {

diff --git a/...metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java b/...metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerIdGenerator.java
@@ -95,7 +95,7 @@ private CompletableFuture<Long> internalGenerateShortLedgerId() {
                     // delete the znode for id generation
                     store.delete(stat.getPath(), Optional.empty()).
                             exceptionally(ex -> {
-                                log.warn("Exception during deleting node for id generation : {}", ex);
+                                log.warn("Exception during deleting node for id generation: ", ex);
                                 return null;
                             });
 
@@ -226,7 +226,7 @@ public CompletableFuture<Long> generateLedgerIdImpl(final String prefix) {
                     // delete the znode for id generation
                     store.delete(stat.getPath(), Optional.empty()).
                             exceptionally(ex -> {
-                                log.warn("Exception during deleting node for id generation : {}", ex);
+                                log.warn("Exception during deleting node for id generation: ", ex);
                                 return null;
                             });
 

diff --git a/...egration/src/test/java/org/apache/pulsar/tests/integration/compaction/TestCompaction.java b/...egration/src/test/java/org/apache/pulsar/tests/integration/compaction/TestCompaction.java
@@ -288,7 +288,7 @@ private static void waitAndVerifyCompacted(PulsarClient client, String topic,
                  .readCompacted(true).subscriptionName(sub).subscribe()) {
                 Message<String> m = consumer.receive();
                 assertEquals(m.getKey(), expectedKey);
-                if (m.getValue() == expectedValue) {
+                if (m.getValue().equals(expectedValue)) {
                     break;
                 }
             }