forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[build] Use absolute path to locate license and checkstyle plugin con…
…fig (apache#8918) ### Motivation Fixes apache#8911, compiling a sub module individually in the sub module directory Previously, the maven build failed if executed in other than the root directory if the license or checkstyle checks were run since those plugins weren't able to find their configuration. ### Modifications - use proposed solution of https://stackoverflow.com/a/37965143 to set a property `pulsar.basedir` which contains the absolute path to the root directory - all other solutions don't seem to work universally in all projects, for example `project.parent.basedir` isn't available in the root project and not all projects necessarily have the root project as their parent project. - when running `license:check` or `checkstyle:checkstyle` directly, it is necessary to add `initialize` phase to the command line, since the `pulsar.basedir` property gets set in the `initialize` phase. for example: `mvn initialize license:check` or `mvn initialize checkstyle:checkstyle` - This should be fine since the maven best practice is to use lifecycle phases such as `mvn verify` instead of listing plugin goals on the command line.
- Loading branch information
Showing
8 changed files
with
49 additions
and
147 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters