forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
maxTopicsPerNamespace check should exclude system topic. (apache#10850)
### Motivation
The current maxTopicsPerNamespace check logic contains system topics, but it should be excluded. As the even if we turn off `allowAutoTopicCreation`, the systemtopic will auto creation too.
### Modifications
1. Exclude the system topics for the maxTopicsPerNamespace logic.
2. SystemTopic add the missed logic, such as `__transaction_buffer_snapshot` 、start with the `__transaction_buffer_snapshot` end with the `__transaction_pending_ack`.
In addition, why is mytopic-partition--1 is a partitioned topic（with --）? Which version of us uses this logic?
```java
// NOTE: Following behavior is not right actually, but for the backward compatibility, it shouldn't be changed
assertEquals(TopicName.getPartitionIndex("mytopic-partition--1"), 1);
assertEquals(TopicName.getPartitionIndex("mytopic-partition-00"), 0);
assertEquals(TopicName.getPartitionIndex("mytopic-partition-012"), 12);
```
this testcase added with apache@dd8be83#diff-445b0cfa56ca0c784df78e73d9294f2a37f079ca3c15c345b03c09d56f81ebffR204 by @BewareMyPower- Loading branch information
Showing
6 changed files
with
120 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/SystemTopicClientTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.broker.systopic; | ||
|
|
||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
| import org.apache.pulsar.common.naming.TopicName; | ||
| import org.junit.Test; | ||
|
|
||
| public class SystemTopicClientTest { | ||
|
|
||
| @Test | ||
| public void testIsSystemTopic() { | ||
| assertFalse(SystemTopicClient.isSystemTopic(TopicName.get("test"))); | ||
| assertFalse(SystemTopicClient.isSystemTopic(TopicName.get("public/default/test"))); | ||
| assertFalse(SystemTopicClient.isSystemTopic(TopicName.get("persistent://public/default/test"))); | ||
| assertFalse(SystemTopicClient.isSystemTopic(TopicName.get("non-persistent://public/default/test"))); | ||
|
|
||
| assertTrue(SystemTopicClient.isSystemTopic(TopicName.get("__change_events"))); | ||
| assertTrue(SystemTopicClient.isSystemTopic(TopicName.get("__change_events-partition-0"))); | ||
| assertTrue(SystemTopicClient.isSystemTopic(TopicName.get("__change_events-partition-1"))); | ||
| assertTrue(SystemTopicClient.isSystemTopic(TopicName.get("__transaction_buffer_snapshot"))); | ||
| assertTrue(SystemTopicClient.isSystemTopic(TopicName.get("__transaction_buffer_snapshot-partition-0"))); | ||
| assertTrue(SystemTopicClient.isSystemTopic(TopicName.get("__transaction_buffer_snapshot-partition-1"))); | ||
| assertTrue(SystemTopicClient.isSystemTopic(TopicName | ||
| .get("topicxxx-partition-0-multiTopicsReader-f433329d68__transaction_pending_ack"))); | ||
| assertTrue(SystemTopicClient.isSystemTopic( | ||
| TopicName.get("topicxxx-multiTopicsReader-f433329d68__transaction_pending_ack"))); | ||
|
|
||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters