Skip to content

Commit

Permalink
Reset dep install. Discover strange bundle dep bug
Browse files Browse the repository at this point in the history
The `tap` package bundles `import-jsx`, which in turn bundles
`@babel/core` and a bunch of other stuff.

However, even though `@babel/core` is in the bundle, it's getting placed
in the tree at the root.  This is a mistake.

Because the node is placed, and not given the `extraneous` flag, in the
ideal tree building process, when reified, it goes ahead and puts it in
place.  When reading the actual tree, we see a valid hidden lockfile,
which contains the module, and it doens't have the extraneous flag.  So
everything seems fine.

Remove the hidden lockfile, and the problem presents itself.

Corrected here through some arduous and painstaking manual installs, so
at least we have the tree in the state it *should* be for now.  But this
is a bug in arborist that must be fixed asap.

Re: npm#1597
  • Loading branch information
isaacs committed Aug 4, 2020
1 parent 05990d9 commit 8981fc9
Show file tree
Hide file tree
Showing 1,092 changed files with 1,184 additions and 51,657 deletions.
3 changes: 1 addition & 2 deletions node_modules/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

This file was deleted.

47 changes: 0 additions & 47 deletions node_modules/are-we-there-yet/node_modules/readable-stream/LICENSE

This file was deleted.

This file was deleted.

Loading

0 comments on commit 8981fc9

Please sign in to comment.