Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integer value column for escapeDefault #290

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

fagai
Copy link
Contributor

@fagai fagai commented Dec 8, 2023

version: 2.4.0
database: postgresql

$this->table('example')
    ->addColumn('count', 'biginteger', ['default' => 0])
    ->create();
Fatal error: Uncaught TypeError: Phoenix\Database\QueryBuilder\PgsqlQueryBuilder::sanitizeSingleQuote(): Argument #1 ($input) must be of type string, int given, called in /var/app/vendor/lulco/phoenix/src/Database/QueryBuilder/PgsqlQueryBuilder.php on line 241 and defined in /var/app/vendor/lulco/phoenix/src/Database/QueryBuilder/PgsqlQueryBuilder.php:351

@lulco
Copy link
Owner

lulco commented Dec 8, 2023

Hi @fagai can you please provide also unit test and fix for mysql query builder (https://github.com/lulco/phoenix/blob/master/src/Database/QueryBuilder/MysqlQueryBuilder.php#L240) too? Thanks

@fagai
Copy link
Contributor Author

fagai commented Dec 8, 2023

@lulco fixed.

@lulco lulco merged commit a092e34 into lulco:master Dec 8, 2023
@lulco
Copy link
Owner

lulco commented Dec 8, 2023

Thank you very much!

@fagai fagai deleted the patch-1 branch December 13, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants