Merge pull request #100 from lumoslabs/fix-schema-cache

fix schema cache
lumoslabs · Jan 17, 2020 · d0c02b3 · d0c02b3
2 parents ccdb78c + 7d06e7e
commit d0c02b3
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,11 @@ Change Log
 
 All notable changes to this project will be documented in this file using [Semantic Versioning](http://semver.org/).
 
+## [0.4.6] - 2020-01-17
+### Fixed
+- Fix issue with schema cache
+- Fix style for schemas page
+
 ## [0.4.5] - 2020-01-15
 ### Fixed
 - Fix style for schemas page

diff --git a/README.md b/README.md
@@ -191,3 +191,4 @@ You can manage your env variables in a .env file
 
 
 Unless otherwise noted, all Aleph source files are made available under the terms of the [MIT License](https://github.com/lumoslabs/aleph/blob/master/LICENSE)
+
diff --git a/aleph.gemspec b/aleph.gemspec
@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'aleph_analytics'
-  s.version     = '0.4.5'
+  s.version     = '0.4.6'
   s.date        = '2020-01-15'
   s.summary     = 'Redshift/Snowflake analytics platform'
   s.description = 'The best way to develop and share queries/investigations/results within an analytics team'

diff --git a/app/assets/stylesheets/schemas.css.sass b/app/assets/stylesheets/schemas.css.sass
@@ -24,6 +24,9 @@
       white-space: pre
       text-transform: lowercase
 
+    form
+      margin-left: 15px
+
   // remove border and shadow on input forms
   input
     border: none

diff --git a/lib/schemas/descriptor.rb b/lib/schemas/descriptor.rb
@@ -24,7 +24,6 @@ class Descriptor
 
     def initialize(role)
       @role = role
-      @cache = []
 
       Rails.logger.info("Start schema refresher thread for #{@role}")
       @refresher_thread = Thread.new{ schema_refresher }
@@ -56,10 +55,7 @@ def key
     private
 
     def retrieve
-      if !@cache.present?
-        @cache = redis_retrieve
-      end
-      return @cache
+      redis_retrieve
     end
 
     def schema_refresher
@@ -78,7 +74,7 @@ def refresh_schema
 
       if result
         redis_store!(filter_tables(result.to_a))
-        @cache = redis_retrieve
+        redis_retrieve
       end
     end
Original file line number	Diff line number	Diff line change
Expand Up		@@ -191,3 +191,4 @@ You can manage your env variables in a .env file


		Unless otherwise noted, all Aleph source files are made available under the terms of the [MIT License](https://github.com/lumoslabs/aleph/blob/master/LICENSE)