Skip to content

Commit

Permalink
Return correct type from OpenSSLStreamAdapter::VerifyPeerCertificate.
Browse files Browse the repository at this point in the history
The function signature expects to return a "bool" but in one code path it
returned "0".

BUG=None

Review-Url: https://codereview.webrtc.org/2742893002
Cr-Commit-Position: refs/heads/master@{#17156}
  • Loading branch information
fancycode authored and Commit bot committed Mar 10, 2017
1 parent 8f33fb3 commit f8f457b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion webrtc/base/opensslstreamadapter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ bool OpenSSLStreamAdapter::VerifyPeerCertificate() {
Buffer computed_digest(digest, digest_length);
if (computed_digest != peer_certificate_digest_value_) {
LOG(LS_WARNING) << "Rejected peer certificate due to mismatched digest.";
return 0;
return false;
}
// Ignore any verification error if the digest matches, since there is no
// value in checking the validity of a self-signed cert issued by untrusted
Expand Down

0 comments on commit f8f457b

Please sign in to comment.