LinGui: support multi-pass CQ with VP9

luokery · Apr 6, 2024 · c8ea8a9 · c8ea8a9
1 parent 0ccd2ba
commit c8ea8a9
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/gtk/src/queuehandler.c b/gtk/src/queuehandler.c
@@ -293,23 +293,32 @@ static void queue_update_summary (GhbValue * queueDict, signal_user_data_t *ud)
     {
         // ABR
         int br = ghb_dict_get_int(uiDict, "VideoAvgBitrate");
-        if (!multi_pass)
+        if (multi_pass && hb_video_multipass_is_supported(video_encoder->codec))
         {
-            g_string_append_printf(str, _("%s, Bitrate %dkbps"),
+            g_string_append_printf(str, _("%s, Bitrate %dkbps (Multi Pass)"),
                                    video_encoder->name, br);
         }
         else
         {
-            g_string_append_printf(str, _("%s, Bitrate %dkbps (Multi Pass)"),
+            g_string_append_printf(str, _("%s, Bitrate %dkbps"),
                                    video_encoder->name, br);
         }
     }
     else
     {
         gdouble quality = ghb_dict_get_double(uiDict, "VideoQualitySlider");
-        g_string_append_printf(str, _("%s, Constant Quality %.4g(%s)"),
+        if (multi_pass && hb_video_cq_multipass_is_supported(video_encoder->codec))
+        {
+            g_string_append_printf(str, _("%s, Constant Quality %.4g(%s) (Multi Pass)"),
                                video_encoder->name, quality,
                                hb_video_quality_get_name(video_encoder->codec));
+        }
+        else
+        {
+            g_string_append_printf(str, _("%s, Constant Quality %.4g(%s)"),
+                               video_encoder->name, quality,
+                               hb_video_quality_get_name(video_encoder->codec));
+        }
     }
     const char * enc_preset  = NULL;
     const char * enc_tune    = NULL;

diff --git a/gtk/src/ui/ghb.ui b/gtk/src/ui/ghb.ui
@@ -3523,7 +3523,6 @@ to limit instantaneous bitrate, look into x264&apos;s vbv-bufsize and vbv-maxrat
                                 <child>
                                   <object class="GtkBox" id="VideoMultiPassBox">
                                     <property name="spacing">20</property>
-                                    <property name="margin-start">10</property>
                                     <child>
                                       <object class="GtkCheckButton" id="VideoMultiPass">
                                         <property name="label" translatable="yes">Multi-Pass Encoding</property>

diff --git a/gtk/src/videohandler.c b/gtk/src/videohandler.c
@@ -79,7 +79,8 @@ ghb_update_multipass(signal_user_data_t *ud)
     bool constant_quality = ghb_dict_get_bool(ud->settings, "vquality_type_constant");
     if (constant_quality)
     {
-        gtk_widget_set_sensitive(multi_pass, false);
+        bool supports_cq_multi_pass = hb_video_cq_multipass_is_supported(encoder);
+        gtk_widget_set_sensitive(multi_pass, supports_cq_multi_pass);
     }
     else
     {