forked from Netflix/ribbon
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request Netflix#276 from qiangdavidliu/eureka-notification…
…-lb-take2 (take 2 of) Adding eureka aware Loadbalancers that make use of new notification mechanism from eurekClient
- Loading branch information
Showing
16 changed files
with
887 additions
and
163 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
151 changes: 151 additions & 0 deletions
151
...reka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| package com.netflix.niws.loadbalancer; | ||
|
|
||
| import com.google.common.util.concurrent.ThreadFactoryBuilder; | ||
| import com.netflix.discovery.CacheRefreshedEvent; | ||
| import com.netflix.discovery.EurekaClient; | ||
| import com.netflix.discovery.EurekaEvent; | ||
| import com.netflix.discovery.EurekaEventListener; | ||
| import com.netflix.loadbalancer.*; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import javax.inject.Provider; | ||
| import java.util.Date; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.ThreadPoolExecutor; | ||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
| import java.util.concurrent.atomic.AtomicLong; | ||
|
|
||
| /** | ||
| * A server list updater for the {@link com.netflix.loadbalancer.DynamicServerListLoadBalancer} that | ||
| * utilizes eureka's event listener to trigger LB cache updates. | ||
| * | ||
| * Note that when a cache refreshed notification is received, the actual update on the serverList is | ||
| * done on a separate scheduler as the notification is delivered on an eurekaClient thread. | ||
| * | ||
| * @author David Liu | ||
| */ | ||
| public class EurekaNotificationServerListUpdater implements ServerListUpdater { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(EurekaNotificationServerListUpdater.class); | ||
|
|
||
| private static class LazyHolder { | ||
| private static final ExecutorService DEFAULT_SERVER_LIST_UPDATE_EXECUTOR = Executors.newCachedThreadPool( | ||
| new ThreadFactoryBuilder() | ||
| .setNameFormat("EurekaNotificationServerListUpdater-%d") | ||
| .setDaemon(true) | ||
| .build() | ||
| ); | ||
|
|
||
| private static final Thread SHUTDOWN_THREAD = new Thread(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| logger.info("Shutting down the Executor for EurekaNotificationServerListUpdater"); | ||
| try { | ||
| DEFAULT_SERVER_LIST_UPDATE_EXECUTOR.shutdown(); | ||
| Runtime.getRuntime().removeShutdownHook(SHUTDOWN_THREAD); | ||
| } catch (Exception e) { | ||
| // this can happen in the middle of a real shutdown, and that's ok. | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| static { | ||
| Runtime.getRuntime().addShutdownHook(SHUTDOWN_THREAD); | ||
| } | ||
| } | ||
|
|
||
| public static ExecutorService getDefaultRefreshExecutor() { | ||
| return LazyHolder.DEFAULT_SERVER_LIST_UPDATE_EXECUTOR; | ||
| } | ||
|
|
||
| private final AtomicBoolean isActive = new AtomicBoolean(false); | ||
| private final AtomicLong lastUpdated = new AtomicLong(System.currentTimeMillis()); | ||
| private final Provider<EurekaClient> eurekaClientProvider; | ||
| private final ExecutorService refreshExecutor; | ||
|
|
||
| private volatile EurekaEventListener updateListener; | ||
| private volatile EurekaClient eurekaClient; | ||
|
|
||
| public EurekaNotificationServerListUpdater() { | ||
| this(new LegacyEurekaClientProvider()); | ||
| } | ||
|
|
||
| public EurekaNotificationServerListUpdater(final Provider<EurekaClient> eurekaClientProvider) { | ||
| this(eurekaClientProvider, getDefaultRefreshExecutor()); | ||
| } | ||
|
|
||
| public EurekaNotificationServerListUpdater(final Provider<EurekaClient> eurekaClientProvider, ExecutorService refreshExecutor) { | ||
| this.eurekaClientProvider = eurekaClientProvider; | ||
| this.refreshExecutor = refreshExecutor; | ||
| } | ||
|
|
||
| @Override | ||
| public synchronized void start(final UpdateAction updateAction) { | ||
| if (isActive.compareAndSet(false, true)) { | ||
| this.updateListener = new EurekaEventListener() { | ||
| @Override | ||
| public void onEvent(EurekaEvent event) { | ||
| if (event instanceof CacheRefreshedEvent) { | ||
| refreshExecutor.submit(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| try { | ||
| updateAction.doUpdate(); | ||
| lastUpdated.set(System.currentTimeMillis()); | ||
| } catch (Exception e) { | ||
| logger.warn("Failed to update serverList", e); | ||
| } | ||
| } | ||
| }); // fire and forget | ||
| } | ||
| } | ||
| }; | ||
| if (eurekaClient == null) { | ||
| eurekaClient = eurekaClientProvider.get(); | ||
| } | ||
| if (eurekaClient != null) { | ||
| eurekaClient.registerEventListener(updateListener); | ||
| } | ||
| } else { | ||
| logger.info("Update listener already registered, no-op"); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public synchronized void stop() { | ||
| if (isActive.compareAndSet(true, false)) { | ||
| if (eurekaClient != null) { | ||
| eurekaClient.unregisterEventListener(updateListener); | ||
| } | ||
| } else { | ||
| logger.info("Not currently active, no-op"); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public String getLastUpdate() { | ||
| return new Date(lastUpdated.get()).toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public long getDurationSinceLastUpdateMs() { | ||
| return System.currentTimeMillis() - lastUpdated.get(); | ||
| } | ||
|
|
||
| @Override | ||
| public int getNumberMissedCycles() { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public int getCoreThreads() { | ||
| if (isActive.get()) { | ||
| if (refreshExecutor != null && refreshExecutor instanceof ThreadPoolExecutor) { | ||
| return ((ThreadPoolExecutor) refreshExecutor).getCorePoolSize(); | ||
| } | ||
| } | ||
| return 0; | ||
| } | ||
| } |
23 changes: 23 additions & 0 deletions
23
ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/LegacyEurekaClientProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package com.netflix.niws.loadbalancer; | ||
|
|
||
| import com.netflix.discovery.DiscoveryManager; | ||
| import com.netflix.discovery.EurekaClient; | ||
|
|
||
| import javax.inject.Provider; | ||
|
|
||
| /** | ||
| * A legacy class to provide eurekaclient via static singletons | ||
| */ | ||
| class LegacyEurekaClientProvider implements Provider<EurekaClient> { | ||
|
|
||
| private volatile EurekaClient eurekaClient; | ||
|
|
||
| @Override | ||
| public synchronized EurekaClient get() { | ||
| if (eurekaClient == null) { | ||
| eurekaClient = DiscoveryManager.getInstance().getDiscoveryClient(); | ||
| } | ||
|
|
||
| return eurekaClient; | ||
| } | ||
| } |
Oops, something went wrong.