dpif-netdev: Update comment about flow installation race.

Userspace datapath uses per-PMD flow tables/classifiers for a long time. However, it was decided to keep this race window to not block revalidators. Comment should be updated to reflect the current state. Fixes: 1c1e46e ("dpif-netdev: Add per-pmd flow-table/classifier.") Signed-off-by: Ilya Maximets <[email protected]> Reviewed-by: Greg Rose <[email protected]> Signed-off-by: Ian Stokes <[email protected]>
lut777 · Apr 18, 2019 · af741ca · af741ca
1 parent b137383
commit af741ca
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
@@ -6549,8 +6549,7 @@ handle_packet_upcall(struct dp_netdev_pmd_thread *pmd,
          * could have already been installed since we last did the flow
          * lookup before upcall.  This could be solved by moving the
          * mutex lock outside the loop, but that's an awful long time
-         * to be locking everyone out of making flow installs.  If we
-         * move to a per-core classifier, it would be reasonable. */
+         * to be locking revalidators out of making flow modifications. */
         ovs_mutex_lock(&pmd->flow_mutex);
         netdev_flow = dp_netdev_pmd_lookup_flow(pmd, key, NULL);
         if (OVS_LIKELY(!netdev_flow)) {