Refactoring

luuhoangnam · Mar 20, 2015 · aa0be17 · aa0be17
1 parent 983d3b7
commit aa0be17
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 24 deletions.
diff --git a/src/Comment.php b/src/Comment.php
@@ -35,18 +35,13 @@ class Comment extends Object
     /**
      * Relation to profile who make this comment
      *
-     * @param string $profile Profile class
+     * @param string $type Profile class
      *
      * @return EdgeOut
      */
-    public function owner($profile = null)
+    public function owner($type = null)
     {
-        if ( ! is_null($profile))
-            if ( ! (new $profile) instanceof Profile)
-                throw new \InvalidArgumentException("[{$profile}] class must be inheritance from Namest\\Facebook\\Profile");
-
-        if (is_null($profile))
-            $profile = Profile::class;
+        $profile = $this->makeProfileFromClassName($type);
 
         return $this->belongsTo($profile, 'LEAVE', false, Edge::OUT);
     }

diff --git a/src/Object.php b/src/Object.php
@@ -869,4 +869,21 @@ public function deleteNode()
 
         return $node->delete();
     }
+
+    /**
+     * @param string $profile
+     *
+     * @return string
+     */
+    protected function makeProfileFromClassName($profile = null)
+    {
+        if ( ! is_null($profile))
+            if ( ! (new $profile) instanceof Profile)
+                throw new \InvalidArgumentException("[{$profile}] class must be inheritance from Namest\\Facebook\\Profile");
+
+        if (is_null($profile))
+            $profile = Profile::class;
+
+        return $profile;
+    }
 }
diff --git a/src/Photo.php b/src/Photo.php
@@ -29,18 +29,13 @@ class Photo extends Object
     ];
 
     /**
-     * @param string $profile Profile class
+     * @param string $type Profile class
      *
      * @return EdgeOut
      */
-    public function uploader($profile = null)
+    public function uploader($type = null)
     {
-        if ( ! is_null($profile))
-            if ( ! (new $profile) instanceof Profile)
-                throw new \InvalidArgumentException("[{$profile}] class must be inheritance from Namest\\Facebook\\Profile");
-
-        if (is_null($profile))
-            $profile = Profile::class;
+        $profile = $this->makeProfileFromClassName($type);
 
         return $this->belongsTo($profile, 'UPLOADED', null, Edge::OUT);
     }

diff --git a/src/Post.php b/src/Post.php
@@ -34,18 +34,13 @@ class Post extends Object
     ];
 
     /**
-     * @param string $profile Profile class
+     * @param string $type Profile class
      *
      * @return EdgeOut
      */
-    public function publisher($profile = null)
+    public function publisher($type = null)
     {
-        if ( ! is_null($profile))
-            if ( ! (new $profile) instanceof Profile)
-                throw new \InvalidArgumentException("[{$profile}] class must be inheritance from Namest\\Facebook\\Profile");
-
-        if (is_null($profile))
-            $profile = Profile::class;
+        $profile = $this->makeProfileFromClassName($type);
 
         return $this->belongsTo($profile, 'PUBLISHED', null, Edge::OUT);
     }