CRL critical extension bugfix

More importantly, port CRL test from boringSSL crypto/x509/x509_test.cc Reviewed-by: Richard Levitte <[email protected]> (Merged from openssl#1775)
lvega1990 · Dec 14, 2016 · 2b40699 · 2b40699
1 parent 99f2f1d
commit 2b40699
Show file tree

Hide file tree

Showing 4 changed files with 381 additions and 3 deletions.
diff --git a/crypto/x509/x_crl.c b/crypto/x509/x_crl.c
@@ -213,7 +213,7 @@ static int crl_cb(int operation, ASN1_VALUE **pval, const ASN1_ITEM *it,
                 if ((nid == NID_issuing_distribution_point)
                     || (nid == NID_authority_key_identifier)
                     || (nid == NID_delta_crl))
-                    break;;
+                    continue;
                 crl->flags |= EXFLAG_CRITICAL;
                 break;
             }

diff --git a/test/build.info b/test/build.info
@@ -19,7 +19,7 @@ IF[{- !$disabled{tests} -}]
           randtest dhtest enginetest casttest \
           bftest ssltest_old dsatest exptest rsa_test \
           evp_test evp_extra_test igetest v3nametest v3ext \
-          danetest p5_crpt2_test bad_dtls_test \
+          crltest danetest p5_crpt2_test bad_dtls_test \
           constant_time_test verify_extra_test clienthellotest \
           packettest asynctest secmemtest srptest memleaktest \
           dtlsv1listentest ct_test threadstest afalgtest d2i_test \
@@ -171,6 +171,10 @@ IF[{- !$disabled{tests} -}]
   INCLUDE[v3nametest]=../include
   DEPEND[v3nametest]=../libcrypto
 
+  SOURCE[crltest]=crltest.c testutil.c test_main.c
+  INCLUDE[crltest]=../include
+  DEPEND[crltest]=../libcrypto
+
   SOURCE[v3ext]=v3ext.c
   INCLUDE[v3ext]=../include
   DEPEND[v3ext]=../libcrypto