Set cmake_minimum_required(VERSION 3.1.0 FATAL_ERROR)

Removed set CMAKE_BUILD_TYPE
lxqt · Nov 18, 2018 · 8cfd84f · 8cfd84f
1 parent 8f507fe
commit 8cfd84f
Show file tree

Hide file tree

Showing 12 changed files with 10 additions and 23 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,6 +1,11 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
+cmake_minimum_required(VERSION 3.1.0 FATAL_ERROR)
+# CMP0000: Call the cmake_minimum_required() command at the beginning of the top-level
+# CMakeLists.txt file even before calling the project() command.
+# The cmake_minimum_required(VERSION) command implicitly invokes the cmake_policy(VERSION)
+# command to specify that the current project code is written for the given range of CMake
+# versions.
 project(lxqt-config)
+
 set(LXQT_CONFIG_PROJECT "${PROJECT_NAME}")
 
 option(UPDATE_TRANSLATIONS "Update source translation translations/*.ts files" OFF)
@@ -29,10 +34,6 @@ find_package(lxqt REQUIRED)
 include(LXQtPreventInSourceBuilds)
 include(LXQtCompilerSettings NO_POLICY_SCOPE)
 
-if(NOT CMAKE_BUILD_TYPE)
-    set(CMAKE_BUILD_TYPE Release)
-endif()
-
 # Patch Version
 set(LXQT_CONFIG_PATCH_VERSION 0)
 

diff --git a/liblxqt-config-cursor/CMakeLists.txt b/liblxqt-config-cursor/CMakeLists.txt
@@ -1,6 +1,6 @@
 project(lxqt-config-cursor)
-find_package(X11 REQUIRED)
 
+find_package(X11 REQUIRED)
 find_package(XCB REQUIRED xcb)
 include_directories(${XCB_INCLUDE_DIRS})
 link_libraries(${XCB_LIBRARIES})

diff --git a/liblxqt-config-cursor/translations/CMakeLists.txt b/liblxqt-config-cursor/translations/CMakeLists.txt
@@ -1,5 +1,3 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
 project(lxqt-config-cursor)
 
 build_component("." "")
diff --git a/lxqt-config-appearance/translations/CMakeLists.txt b/lxqt-config-appearance/translations/CMakeLists.txt
@@ -1,5 +1,3 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
 project(lxqt-config-appearance)
 
 build_component("." "")
diff --git a/lxqt-config-brightness/translations/CMakeLists.txt b/lxqt-config-brightness/translations/CMakeLists.txt
@@ -1,5 +1,3 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
 project(lxqt-config-brightness)
 
 build_component("." "")
diff --git a/lxqt-config-file-associations/translations/CMakeLists.txt b/lxqt-config-file-associations/translations/CMakeLists.txt
@@ -1,5 +1,3 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
 project(lxqt-config-file-associations)
 
 build_component("." "")
diff --git a/lxqt-config-input/CMakeLists.txt b/lxqt-config-input/CMakeLists.txt
@@ -1,4 +1,5 @@
 project(lxqt-config-input)
+
 find_package(X11 REQUIRED)
 
 include_directories(

diff --git a/lxqt-config-input/translations/CMakeLists.txt b/lxqt-config-input/translations/CMakeLists.txt
@@ -1,5 +1,3 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
 project(lxqt-config-input)
 
 build_component("." "")
diff --git a/lxqt-config-locale/translations/CMakeLists.txt b/lxqt-config-locale/translations/CMakeLists.txt
@@ -1,5 +1,3 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
 project(lxqt-config-locale)
 
 build_component("." "")
diff --git a/lxqt-config-monitor/CMakeLists.txt b/lxqt-config-monitor/CMakeLists.txt
@@ -80,3 +80,4 @@ target_link_libraries(${PROJECT_NAME}
 install(TARGETS ${PROJECT_NAME} RUNTIME DESTINATION ${CMAKE_INSTALL_FULL_BINDIR})
 install(FILES ${DESKTOP_FILES} DESTINATION "${CMAKE_INSTALL_FULL_DATADIR}/applications")
 install(FILES ${ICONS} DESTINATION "${CMAKE_INSTALL_FULL_DATADIR}/lxqt/icons")
+
diff --git a/lxqt-config-monitor/translations/CMakeLists.txt b/lxqt-config-monitor/translations/CMakeLists.txt
@@ -1,5 +1,3 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
 project(lxqt-config-monitor)
 
 build_component("." "")
diff --git a/src/translations/CMakeLists.txt b/src/translations/CMakeLists.txt
@@ -1,5 +1,3 @@
-cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR)
-
 project(lxqt-config)
 
 build_component("." "")
Original file line number	Diff line number	Diff line change
Expand Up		@@ -80,3 +80,4 @@ target_link_libraries(${PROJECT_NAME}
		install(TARGETS ${PROJECT_NAME} RUNTIME DESTINATION ${CMAKE_INSTALL_FULL_BINDIR})
		install(FILES ${DESKTOP_FILES} DESTINATION "${CMAKE_INSTALL_FULL_DATADIR}/applications")
		install(FILES ${ICONS} DESTINATION "${CMAKE_INSTALL_FULL_DATADIR}/lxqt/icons")