datapath-windows: Fix nbl cleanup when memory allocation fails

StartNblIngressError should be called only when an NBL hasn't been modified. In this case the nbl context was initialized. Rely on existing packet completion mechanism to cleanup the NBL. Found while testing with DriverVerifier with limited memory setting enabled. Signed-off-by: Sairam Venugopal <[email protected]> Acked-by: Anand Kumar <[email protected]> Signed-off-by: Alin Gabriel Serdean <[email protected]>
lynn901 · Mar 13, 2019 · 9c60fd4 · 9c60fd4
1 parent a47e2db
commit 9c60fd4
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/datapath-windows/ovsext/PacketIO.c b/datapath-windows/ovsext/PacketIO.c
@@ -283,9 +283,8 @@ OvsStartNBLIngress(POVS_SWITCH_CONTEXT switchContext,
                 RtlInitUnicodeString(&filterReason,
                                      L"Cannot allocate NBLs with single NB.");
 
-                OvsStartNBLIngressError(switchContext, curNbl,
-                                        sendCompleteFlags, &filterReason,
-                                        NDIS_STATUS_RESOURCES);
+                OvsAddPktCompletionList(&completionList, TRUE, sourcePort,
+                                        curNbl, 0, &filterReason);
                 continue;
             }