Filter out RegExp special characters in filter (keybase#16322)

shared/chat/inbox/container/filtered.js

@@ -3,6 +3,7 @@
 import * as Types from '../../../constants/types/chat2'
 import * as Constants from '../../../constants/chat2'
 import {memoize} from '../../../util/memoize'
+import {makeInsertMatcher} from '../../../util/string'
 import type {RowItem} from '../index.types'
 
 const score = (lcFilter: string, lcYou: string, names: Array<string>, insertMatcher: RegExp): number => {
@@ -107,14 +108,7 @@ const getFilteredRowsAndMetadata = memoize<Types.MetaMap, string, string, void,
     const metas = metaMap.valueSeq().toArray()
     const lcFilter = filter.toLowerCase()
     const lcYou = username.toLowerCase()
-    const insertMatcher = new RegExp(
-      `${filter
-        .replace(/ |#/g, '')
-        .split('')
-        .map(c => `${c}.*?`)
-        .join('')}`,
-      'i'
-    )
+    const insertMatcher = makeInsertMatcher(filter)
     const rows: Array<RowItem> = metas
       .map(meta => {
         if (!Constants.isValidConversationIDKey(meta.conversationIDKey)) {

shared/util/string.js

@@ -5,6 +5,21 @@ export function pluralize(str: string, count?: number): string {
   return count === 1 ? str : str.endsWith('s') ? str : `${str}s`
 }
 
+// Returns a RegExp that matches any string with the given filter
+// string (with special characters removed) as a subsequence.
+export function makeInsertMatcher(filter: string): RegExp {
+  // Clear RegExp special characters: see
+  // https://stackoverflow.com/a/9310752 .
+  return new RegExp(
+    `${filter
+      .replace(/[-[\]{}()*+?.,\\^$|#\s]/g, '')
+      .split('')
+      .map(c => `${c}.*?`)
+      .join('')}`,
+    'i'
+  )
+}
+
 export function toStringForLog(a: any): string {
   switch (typeof a) {
     case 'undefined':