address nits

config/config.go

@@ -353,8 +353,8 @@ func getNetworkConfig(v *viper.Viper, halflife time.Duration) (network.Config, e
 		return network.Config{}, fmt.Errorf("%s must be >= 0", NetworkPeerListGossipFreqKey)
 	case config.GetVersionTimeout < 0:
 		return network.Config{}, fmt.Errorf("%s must be >= 0", NetworkGetVersionTimeoutKey)
-	case config.PeerListStakerGossipFraction < 0:
-		return network.Config{}, fmt.Errorf("%s must be >= 0", NetworkPeerListStakerGossipFractionKey)
+	case config.PeerListStakerGossipFraction < 1:
+		return network.Config{}, fmt.Errorf("%s must be >= 1", NetworkPeerListStakerGossipFractionKey)
 	case config.MaxReconnectDelay < 0:
 		return network.Config{}, fmt.Errorf("%s must be >= 0", NetworkMaxReconnectDelayKey)
 	case config.InitialReconnectDelay < 0:
@@ -772,15 +772,15 @@ func readSubnetConfigs(subnetConfigPath string, subnetIDs []ids.ID, defaultSubne
 	for _, subnetID := range subnetIDs {
 		filePath := filepath.Join(subnetConfigPath, subnetID.String()+subnetConfigFileExt)
 		fileInfo, err := os.Stat(filePath)
-		if errors.Is(err, os.ErrNotExist) {
+		switch {
+		case errors.Is(err, os.ErrNotExist):
 			// this subnet config does not exist, move to the next one
 			continue
-		}
-		if err != nil {
+		case err != nil:
 			return nil, err
+		case fileInfo.IsDir():
 		}
-
-		if fileInfo.IsDir() {
+		if err != nil {
 			return nil, fmt.Errorf("%q is a directory, expected a file", fileInfo.Name())
 		}
 

config/flags.go

@@ -144,10 +144,10 @@ func addNodeFlags(fs *flag.FlagSet) {
 	fs.Duration(NetworkPingTimeoutKey, constants.DefaultPingPongTimeout, "Timeout value for Ping-Pong with a peer.")
 	fs.Duration(NetworkPingFrequencyKey, constants.DefaultPingFrequency, "Frequency of pinging other peers.")
 
-	fs.Bool(NetworkCompressionEnabledKey, true, "If true, compress Put, PushQuery, PeerList and Multiput messages sent to peers that support compression")
+	fs.Bool(NetworkCompressionEnabledKey, true, "If true, compress certain outbound messages. This node will be able to parse compressed inbound messages regardless of this flag's value")
 	fs.Duration(NetworkMaxClockDifferenceKey, time.Minute, "Max allowed clock difference value between this node and peers.")
 	fs.Bool(NetworkAllowPrivateIPsKey, true, "Allows the node to connect peers with private IPs")
-	fs.Bool(NetworkRequireValidatorToConnectKey, false, "Requires a connection to have a least one validator to be made")
+	fs.Bool(NetworkRequireValidatorToConnectKey, false, "If true, this node will only maintain a connection with another node if this node is a validator, the other node is a validator, or the other node is a beacon")
 	// Peer alias configuration
 	fs.Duration(PeerAliasTimeoutKey, 10*time.Minute, "How often the node will attempt to connect "+
 		"to an IP address previously associated with a peer (i.e. a peer alias).")
@@ -163,7 +163,7 @@ func addNodeFlags(fs *flag.FlagSet) {
 	fs.Duration(ConsensusShutdownTimeoutKey, 5*time.Second, "Timeout before killing an unresponsive chain.")
 	fs.Uint(ConsensusGossipAcceptedFrontierSizeKey, 35, "Number of peers to gossip to when gossiping accepted frontier")
 	fs.Uint(ConsensusGossipOnAcceptSizeKey, 20, "Number of peers to gossip to each accepted container to")
-	fs.Uint(AppGossipNonValidatorSizeKey, 2, "Number of peers to gossip an AppGossip message to")
+	fs.Uint(AppGossipNonValidatorSizeKey, 2, "Number of peers (which may be validators or non-validators) to gossip an AppGossip message to")
 	fs.Uint(AppGossipValidatorSizeKey, 4, "Number of validators to gossip an AppGossip message to")
 
 	// Inbound Throttling

database/common.go

@@ -1,4 +1,4 @@
-// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
+// (c) 2019-2021, Ava Labs, Inc. All rights reserved.
 // See the file LICENSE for licensing terms.
 
 package database

health/check.go

@@ -1,4 +1,4 @@
-// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
+// (c) 2019-2021, Ava Labs, Inc. All rights reserved.
 // See the file LICENSE for licensing terms.
 
 package health

health/checkable.go

@@ -1,4 +1,4 @@
-// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
+// (c) 2019-2021, Ava Labs, Inc. All rights reserved.
 // See the file LICENSE for licensing terms.
 
 package health

health/service.go

@@ -1,4 +1,4 @@
-// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
+// (c) 2019-2021, Ava Labs, Inc. All rights reserved.
 // See the file LICENSE for licensing terms.
 
 package health

utils/storage/storage_common.go

@@ -29,29 +29,31 @@ func FileExists(filePath string) (bool, error) {
 func ReadFileWithName(parentDir string, fileNameNoExt string) ([]byte, error) {
 	filePath := filepath.Join(parentDir, fileNameNoExt)
 	files, err := filepath.Glob(filePath + ".*") // all possible extensions
-	if err != nil {
+	switch {
+	case err != nil:
 		return nil, err
-	}
-	if len(files) > 1 {
+	case len(files) > 1:
 		return nil, fmt.Errorf(`too many files matched "%s.*" in %s`, fileNameNoExt, parentDir)
-	}
-	if len(files) == 0 { // no file found, return nothing
+	case len(files) == 0:
+		// no file found, return nothing
 		return nil, nil
+	default:
+		return ioutil.ReadFile(files[0])
 	}
-	return ioutil.ReadFile(files[0])
 }
 
 // folderExists checks if a folder exists before we
 // try using it to prevent further errors.
 func FolderExists(filePath string) (bool, error) {
 	info, err := os.Stat(filePath)
-	if err == nil {
-		return info.IsDir(), nil
-	}
-	if errors.Is(err, os.ErrNotExist) {
+	switch {
+	case errors.Is(err, os.ErrNotExist):
 		return false, nil
+	case err != nil:
+		return false, err
+	default:
+		return info.IsDir(), nil
 	}
-	return false, err
 }
 
 func DirSize(path string) (uint64, error) {