Skip to content

Commit

Permalink
Merge pull request kubernetes#38270 from resouer/fix-zone
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 39394, 38270, 39473, 39516, 36243)

Fix wrong skipf parameter

**How to reproduce**

When run e2e test, it reports `%!!(MISSING)d(MISSING)`:
```
STEP: Checking for multi-zone cluster.  Zone count = 1
Dec  6 14:16:43.272: INFO: Zone count is %!!(MISSING)d(MISSING), only run for multi-zone clusters, skipping test
[AfterEach] [k8s.io] Multi-AZ Clusters
```

We need to pass a string parameter to `SkipUnlessAtLeast`
  • Loading branch information
Kubernetes Submit Queue authored Jan 9, 2017
2 parents 73d36ce + 993a99d commit 125bf9c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/e2e/ubernetes_lite.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ var _ = framework.KubeDescribe("Multi-AZ Clusters", func() {
Expect(err).NotTo(HaveOccurred())
}
By(fmt.Sprintf("Checking for multi-zone cluster. Zone count = %d", zoneCount))
framework.SkipUnlessAtLeast(zoneCount, 2, "Zone count is %d, only run for multi-zone clusters, skipping test")
msg := fmt.Sprintf("Zone count is %d, only run for multi-zone clusters, skipping test", zoneCount)
framework.SkipUnlessAtLeast(zoneCount, 2, msg)
// TODO: SkipUnlessDefaultScheduler() // Non-default schedulers might not spread
})
It("should spread the pods of a service across zones", func() {
Expand Down

0 comments on commit 125bf9c

Please sign in to comment.