Skip to content

Commit

Permalink
Hide the CA path in normal operation
Browse files Browse the repository at this point in the history
Most users don't need to interact with it, and it's important they don't
share the rootCA-key.pem file, so let's not lead them there in the first
place. Advanced users can still use "mkcert -CAROOT".

Fixes FiloSottile#282
  • Loading branch information
FiloSottile committed Oct 25, 2020
1 parent ea8260d commit e806823
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ mkcert is a simple tool for making locally-trusted development certificates. It

```
$ mkcert -install
Created a new local CA at "/Users/filippo/Library/Application Support/mkcert" 💥
Created a new local CA 💥
The local CA is now installed in the system trust store! ⚡️
The local CA is now installed in the Firefox trust store (requires browser restart)! 🦊
$ mkcert example.com "*.example.com" example.test localhost 127.0.0.1 ::1
Using the local CA at "/Users/filippo/Library/Application Support/mkcert" ✨
Created a new certificate valid for the following names 📜
- "example.com"
Expand Down
4 changes: 1 addition & 3 deletions cert.go
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,6 @@ func (m *mkcert) makeCertFromCSR() {
func (m *mkcert) loadCA() {
if !pathExists(filepath.Join(m.CAROOT, rootName)) {
m.newCA()
} else {
log.Printf("Using the local CA at \"%s\"\n", m.CAROOT)
}

certPEMBlock, err := ioutil.ReadFile(filepath.Join(m.CAROOT, rootName))
Expand Down Expand Up @@ -341,7 +339,7 @@ func (m *mkcert) newCA() {
&pem.Block{Type: "CERTIFICATE", Bytes: cert}), 0644)
fatalIfErr(err, "failed to save CA key")

log.Printf("Created a new local CA at \"%s\" 💥\n", m.CAROOT)
log.Printf("Created a new local CA 💥\n")
}

func (m *mkcert) caUniqueName() string {
Expand Down

0 comments on commit e806823

Please sign in to comment.