Clarify logic

m0003r · Mar 14, 2005 · 1dbc47c · 1dbc47c
1 parent 6e6a1f0
commit 1dbc47c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Zend/zend_ini.c b/Zend/zend_ini.c
@@ -447,10 +447,10 @@ ZEND_API ZEND_INI_MH(OnUpdateBool)
 
 	p = (zend_bool *) (base+(size_t) mh_arg1);
 
-	if (strncasecmp("on", new_value, sizeof("on"))) {
-		*p = (zend_bool) atoi(new_value);
-	} else {
+	if (new_value_length==2	&& strcasecmp("on", new_value)==0) {
 		*p = (zend_bool) 1;
+	} else {
+		*p = (zend_bool) atoi(new_value);
 	}
 	return SUCCESS;
 }