fix for a bug in mailer template causing sorting of backtrace

m0rk · Feb 27, 2010 · 6f40e46 · 6f40e46
1 parent e3b4475
commit 6f40e46
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/app/views/notifications_mailer/notification.erb b/app/views/notifications_mailer/notification.erb
@@ -6,8 +6,11 @@ open in browser >> <%= project_stack_url(@stack.project, @stack) %> <<
   ------------------------------
   <%= section %>
   ------------------------------
-  <% sorted_output(value).each do |array_with_data| %>
-    <%= "#{array_with_data.first}#{': ' + array_with_data.last.inspect if array_with_data.last}" -%>
-  <% end %>
-
-<% end %>
+  <% if section == "backtrace" %>
+    <%= value.join("\n").to_yaml -%>
+  <% else %>
+    <% sorted_output(value).each do |array_with_data| %>
+      <%= "#{array_with_data.first}#{': ' + array_with_data.last.inspect if array_with_data.last}" -%>
+    <% end %>
+  <% end %>  
+<% end %>
diff --git a/config/environment.rb b/config/environment.rb
@@ -46,4 +46,5 @@
   config.gem "authlogic"
   config.gem "mislav-will_paginate", :lib => "will_paginate", :source => "http://gems.github.com"
   config.gem "lukeredpath-simpleconfig", :lib => "simpleconfig"
+  config.gem "ruby-net-ldap", :lib => "net/ldap"
 end
diff --git a/test/unit/notifications_mailer_test.rb b/test/unit/notifications_mailer_test.rb
@@ -74,4 +74,12 @@ class NotificationsMailerTest < ActionMailer::TestCase
     assert_match /http:\/\/example.com\/projects\/#{stack.project.id}\/stacks\/#{stack.id}/, email.body
   end
 
+  test "backtrace should not be sorted" do
+    payload = { "backtrace" => ["b_line", "a_line"] }
+    notification = Factory.create(:notification, :payload => ActiveSupport::JSON.encode(payload))
+
+    email = NotificationsMailer.deliver_notification(notification.stack)
+    assert_match /b_line\n.*a_line/, email.body
+  end
+
 end