Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented fetching articles from arXiv, pubmed, doi functionality & created resuable code & added countries select dropdown for location in createcommunity page #21

Closed
wants to merge 0 commits into from

Conversation

dinakar17
Copy link
Collaborator

  1. In the submit article page, I've added two things: i) Improved code reusability by replacing input fields with reusable components Input.jsx and TextareaField.jsx. ii) Implemented ArticleFetcher component which fetches the articles from the arXiV (ex: arXiv:2106.03744), pubmed (32572182), and doi (10.1007/s00134-020-05985-9)
    articlefetcher
  2. In the createcommunity page, I've implemented two things
    i) Again improved code reusability by replacing input fields with reusable components Input.jsx and TextareaField.jsx.
    ii) Added countries select dropdown using react-tailwindcss-select library for selecting the location.

locationselector

@JyothiSwaroopReddy07
Copy link
Collaborator

JyothiSwaroopReddy07 commented Mar 16, 2024

You are not adding the fetched article to the data base. Just fetching is not enough And Also the search bar design can be better.

You must provide a button to add that particular article to our database. And also check if its already added by anyother user before.

@dinakar17
Copy link
Collaborator Author

articlefetching

Understood. Redesigned the search UI and will try to add the functionalities related to the backend soon.

@JyothiSwaroopReddy07
Copy link
Collaborator

Looks great design. Can you also add "Add Article" Button to add article to database

@JyothiSwaroopReddy07
Copy link
Collaborator

Please Also add the Add Article button and using web-scraping techniques to scrap necessary and useful data which are not exposed by API ENDPoints of arxiv, doi. (pubmed I already Have done)

@dinakar17
Copy link
Collaborator Author

dinakar17 commented Mar 18, 2024

  1. Added a shareable URL link for every comment (review) of the article.

shareable URL link

  1. Implemented the logic to fetch arXiv and doi articles and then add them to the database if that article hasn't been added before.
    articlefetchaddtodatabase

  2. Enhanced Article UI section design by adding tooltips (for clear message) and enhanced style to buttons, text, and other icons
    everythingfine
    The above is also proof everything's working fine without any breaking changes.

  3. Added two unit tests for InputField and Footer using jest and @react-test-library. Also configured babel for parsing jsx files while testing.

@JyothiSwaroopReddy07
Copy link
Collaborator

Sorry for the inconvienence but their are a lot of merge conflicts. Can you resolve them. PR looks great except that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants