Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint/prettier configurations #25

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

turingAlan
Copy link
Contributor

Resolves #20
@JyothiSwaroopReddy07 have implemented all the ESLint and Prettier configurations which will be necessary to maintain a coding standard in this project right now I have kept some linting rules as warn only while they should be error because there are a lot of those issues.
Also, for once we will need to format all the files with the current prettier configuration which will lead to changes in all the files.

@JyothiSwaroopReddy07
Copy link
Collaborator

Can you resolve the merge conflicts.

@turingAlan
Copy link
Contributor Author

turingAlan commented Mar 18, 2024

@JyothiSwaroopReddy07 done also there was a wrong import PostEditModal.jsx in file causing the build to fail which is fixed now.

@turingAlan
Copy link
Contributor Author

Also are we hosting frontend on any managed platform like vercel and render or using a simple ec2 instance if later than we will have to make sure that the instance is running node version greater than 12 if not it will cause the build to fail.

@turingAlan
Copy link
Contributor Author

We will also need to run npm run format which will format each and every JavaScript file according to the local prettier configuration. If we wouldn't do this than in every commit, we will see every unformatted having which has been changed formatted completely.

@turingAlan
Copy link
Contributor Author

@JyothiSwaroopReddy07 shall format all the files in this PR or should I raise another PR for the same?

@JyothiSwaroopReddy07 JyothiSwaroopReddy07 merged commit 4f40cde into m2b3:main Mar 18, 2024
@JyothiSwaroopReddy07
Copy link
Collaborator

Thanks for the pr. Good Work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Prettier Configuration and ESLint Integration for Consistent Code Formatting and Quality Checks.
2 participants