-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint/prettier configurations #25
Conversation
Can you resolve the merge conflicts. |
@JyothiSwaroopReddy07 done also there was a wrong import PostEditModal.jsx in file causing the build to fail which is fixed now. |
Also are we hosting frontend on any managed platform like vercel and render or using a simple ec2 instance if later than we will have to make sure that the instance is running node version greater than 12 if not it will cause the build to fail. |
We will also need to run |
@JyothiSwaroopReddy07 shall format all the files in this PR or should I raise another PR for the same? |
Thanks for the pr. Good Work |
Resolves #20
@JyothiSwaroopReddy07 have implemented all the ESLint and Prettier configurations which will be necessary to maintain a coding standard in this project right now I have kept some linting rules as warn only while they should be error because there are a lot of those issues.
Also, for once we will need to format all the files with the current prettier configuration which will lead to changes in all the files.