chore: swap default expand icon for collapse component #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gabyzif
approved these changes
Nov 20, 2024
| <AntCollapse {...props} /> | ||
| <AntCollapse | ||
| expandIcon={({ isActive }): React.JSX.Element => | ||
| isActive ? <Icon name="dropdownOpen" size="sm" /> : <Icon name="next" size="sm" /> |
There was a problem hiding this comment.
why does the native ant icon not work for us?
There was a problem hiding this comment.
It's a different chevron, same as the Select component. Our chevron came from Design and looks better IMO
There was a problem hiding this comment.
it does look better indeed
nastyastavitskaya
approved these changes
Dec 19, 2024
nastyastavitskaya
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets the default icons for the Collapse component usage and fix table advanced filters docs to use it.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)