Commits

Branch selector

 master

User selector

janakdr

Datepicker

All time

Commit History

Commits on Aug 9, 2021

• Automated rollback of commit 23f171e.

  Show description for 14e4a78
  

  janakdr

  authored and

  copybara-github

  committed
  14e4a78

  Copy full SHA for 14e4a78

• Do visitation of graph for deletion in parallel, using ConcurrentHashMap#forEachEntry. Shaves ~1 second off benchmark build.

  Show description for cd512cf
  

  janakdr

  authored and

  copybara-github

  committed
  cd512cf

  Copy full SHA for cd512cf

Commits on Aug 6, 2021

• Make action cache concurrency-friendly to avoid high contention. Use ConcurrentHashMap so there's no need for locking. Keep entries to be written to disk in a concurrent queue, and look their value…

  Show description for fe6645d
  

  janakdr

  authored and

  copybara-github

  committed
  fe6645d

  Copy full SHA for fe6645d

• Introduce a new NodeEntry#removeReverseDepsFromDoneEntryDueToDeletion method and use it when deleting nodes from the Skyframe graph. We sacrifice some correctness checks for performance: rather tha…

  Show description for d86762c
  

  janakdr

  authored and

  copybara-github

  committed
  d86762c

  Copy full SHA for d86762c

Commits on Aug 5, 2021

• Suggested by nharmata@: use ForkJoinPool for DeletingNodeVisitor and enqueue work in #cpu batches for maximal efficiency. Also clean up some dead code.

  Show description for 9d0d971
  

  janakdr

  authored and

  copybara-github

  committed
  9d0d971

  Copy full SHA for 9d0d971

• Don't interrupt the command thread on an abrupt exit/crash if we are already on the command thread: the interruption is to stop the command thread from proceeding with non-exit work, but if the com…

  Show description for 3a5bea1
  

  janakdr

  authored and

  copybara-github

  committed
  3a5bea1

  Copy full SHA for 3a5bea1

Commits on Aug 4, 2021

• Optimize some parts of Skyframe node deletion, especially for the case of discarding the analysis cache on a configuration change:

  Show description for 3ea7559
  

  janakdr

  authored and

  copybara-github

  committed
  3ea7559

  Copy full SHA for 3ea7559

Commits on Aug 2, 2021

• When outputting a thread dump for a slow interruption, group threads with the same stack trace together, sort the dump by stack length (longer stacks are more likely to be interesting), and insert …

  Show description for 8eba488
  

  janakdr

  authored and

  copybara-github

  committed
  8eba488

  Copy full SHA for 8eba488

• Clear out OOM intentionally thrown in test case.

  Show description for 262cd8a
  

  janakdr

  authored and

  copybara-github

  committed
  262cd8a

  Copy full SHA for 262cd8a

Commits on Jul 31, 2021

• Avoid touching the filesystem to see what the BUILD file for a Starlark extension was: we already have the package, so we can just read it out.

  Show description for 23f171e
  

  janakdr

  authored and

  copybara-github

  committed
  23f171e

  Copy full SHA for 23f171e

Commits on Jul 30, 2021

• RELNOTES: --bep_publish_used_heap_size_post_build is deprecated. Use --memory_profile=/dev/null instead.

  Show description for a512791
  

  janakdr

  authored and

  copybara-github

  committed
  a512791

  Copy full SHA for a512791

Commits on Jul 29, 2021

• Move misplaced period.

  Show description for b9d94c0
  

  janakdr

  authored and

  copybara-github

  committed
  b9d94c0

  Copy full SHA for b9d94c0

• Don't log an exception when there's a batch stat failure: it's not indicative of an underlying Bazel bug.

  Show description for aff83c4
  

  janakdr

  authored and

  copybara-github

  committed
  aff83c4

  Copy full SHA for aff83c4

• In MemoryProfiler, when doing multiple GCs after a phase, use the minimum "heap used" value as the correct one: random allocation of garbage can race with GC and reading the value, so values may be…

  Show description for 23146f2
  

  janakdr

  authored and

  copybara-github

  committed
  23146f2

  Copy full SHA for 23146f2

Commits on Jul 22, 2021

• Remove BAZEL_INTERNAL_BUILD_REQUEST_ID.

  Show description for 0e4f97e
  

  janakdr

  authored and

  copybara-github

  committed
  0e4f97e

  Copy full SHA for 0e4f97e

Commits on Jul 19, 2021

• Remove useless reporter synchronization in SkyframeActionExecutor action output: after unknown commit, there is only one event outputted, so no synchronization is necessary.

  Show description for a52b132
  

  janakdr

  authored and

  copybara-github

  committed
  a52b132

  Copy full SHA for a52b132

• Add debugging info when test target is unexpectedly an alias.

  Show description for 9f4f674
  

  janakdr

  authored and

  copybara-github

  committed
  9f4f674

  Copy full SHA for 9f4f674

Commits on Jul 16, 2021

• Properly initialize TimestampBuilderTestCase now that ArtifactNestedSetFunction is always used. Previously, some other test class in the same target had to call ArtifactNestedSetFunction#createInst…

  Show description for 121756b
  

  janakdr

  authored and

  copybara-github

  committed
  121756b

  Copy full SHA for 121756b

• Qualify Option reference to get rid of IntelliJ warning.

  Show description for 5135793
  

  janakdr

  authored and

  copybara-github

  committed
  5135793

  Copy full SHA for 5135793

Commits on Jul 15, 2021

• Roll-forward of bazelbuild@a95c7b7 with fix: only reset the heapLimiterTriggeredGc bit if we are in a manually triggered GC. This prevents a concurrent non-manually triggered GC from resetting the …

  Show description for 1ab4003
  

  janakdr

  authored and

  copybara-github

  committed
  1ab4003

  Copy full SHA for 1ab4003

Commits on Jul 14, 2021

• Automated rollback of commit a95c7b7.

  Show description for 5d92634
  

  janakdr

  authored and

  copybara-github

  committed
  5d92634

  Copy full SHA for 5d92634

• Move MemoryProfiler final GC and collection to BuildTool#stopRequest, rather than putting it at the end of the normal #buildTargets codepath. This allows it to run even if the build was unsuccessfu…

  Show description for d236be2
  

  janakdr

  authored and

  copybara-github

  committed
  d236be2

  Copy full SHA for d236be2

Commits on Jul 13, 2021

• Make Java build-info properties file deterministic. C++ headers were already deterministic, but make them alphabetical so it's easier to test them.

  Show description for aafaa13
  

  janakdr

  authored and

  copybara-github

  committed
  aafaa13

  Copy full SHA for aafaa13

• "Deflake" FilesystemValueCheckerTest#testPropagatesRuntimeExceptions: bazelbuild@c9f44ec removed the throwable-recording wrapper. I don't think it's worth reintroducing: we don't need to engineer a…

  Show description for 933c301
  

  janakdr

  authored and

  copybara-github

  committed
  933c301

  Copy full SHA for 933c301

Commits on Jul 9, 2021

• Add a bunch more ugly debugging. Eagerly crash on missing mandatory inputs instead of sending a bug report: it just delays the bug report until a little later, making the signature of the crash con…

  Show description for ccdda95
  

  janakdr

  authored and

  copybara-github

  committed
  ccdda95

  Copy full SHA for ccdda95

• Use -1 as a sentinel meaning the version could not be accurately computed in HashAndVersion.

  Show description for 94417c3
  

  janakdr

  authored and

  copybara-github

  committed
  94417c3

  Copy full SHA for 94417c3

Commits on Jul 8, 2021

• Prevent new commands from starting if Bazel is in the middle of crashing: crashing can take quite a long time during clean-up, and it's confusing if another command runs in the middle of it. This b…

  Show description for 8e881f7
  

  janakdr

  authored and

  copybara-github

  committed
  8e881f7

  Copy full SHA for 8e881f7

Commits on Jul 2, 2021

• Allow modules to register a SkyKeyStateReceiver to observe the start of each SkyKey evaluation, when a SkyKey is evaluated, and the start/end of work on another (non-Skyframe) thread that "belongs"…

  Show description for 13b737a
  

  janakdr

  authored and

  copybara-github

  committed
  13b737a

  Copy full SHA for 13b737a

Commits on Jul 1, 2021

• Remove ThrowableRecordingRunnableWrapper from production use: our default uncaught exception handler is preferred.

  Show description for c9f44ec
  

  janakdr

  authored and

  copybara-github

  committed
  c9f44ec

  Copy full SHA for c9f44ec

Commits on Jun 29, 2021

• Remove unnecessary ImmutableIterable and avoid doing an empty Skyframe lookup if there are no client environment variables for an action.

  Show description for 2c05912
  

  janakdr

  authored and

  copybara-github

  committed
  2c05912

  Copy full SHA for 2c05912

Commits on Jun 28, 2021

• Export used gc when memory profiling enabled.

  Show description for 3d58523
  

  janakdr

  authored and

  copybara-github

  committed
  3d58523

  Copy full SHA for 3d58523

• Modify RetainedHeapLimiter to only throw an OOM when it itself triggers a manual GC. Other parts of Blaze can trigger manual GCs, and high memory usage after a manual GC does not mean that Blaze ha…

  Show description for a95c7b7
  

  janakdr

  authored and

  copybara-github

  committed
  a95c7b7

  Copy full SHA for a95c7b7

• Automated rollback of commit ae2a6a2.

  Show description for 223113c
  

  janakdr

  authored and

  copybara-github

  committed
  223113c

  Copy full SHA for 223113c

Commits on Jun 24, 2021

• Distinguish between I/O exceptions caused by user decisions versus environmental issues: symlink cycles are the user's fault, and should have a different exit code from generic I/O exceptions.

  Show description for 5d955f5
  

  janakdr

  authored and

  copybara-github

  committed
  5d955f5

  Copy full SHA for 5d955f5

• Add a flag to drop BuildConfigurationValue.Key nodes when analysis is dropped. They're unlikely to be used again, are relatively cheap to compute if they do have to be recomputed, and cost a fair b…

  Show description for 2f4ed67
  

  janakdr

  authored and

  copybara-github

  committed
  2f4ed67

  Copy full SHA for 2f4ed67

Pagination

Previous

Next