Skip to content

Commit

Permalink
Remove invalid text (dotnet#51820)
Browse files Browse the repository at this point in the history
I found this piece of text which indicate that long time ago,
about 3 years (dotnet/coreclr#16353), ago infra has not .NET core 2.0 on build agents,
and test in this folder cannot be compiled with dotnet sdk
This is not longer true.
Moreother, this project is disabled https://github.com/dotnet/runtime/blob/main/src/tests/Common/dirs.proj#L17
for same amount of time (3 years)
With this PR I want to raise a question, do somebody need this folder, so it can be reenabled, or it can be removed?
  • Loading branch information
kant2002 authored May 5, 2021
1 parent 648407d commit 2ce073a
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,3 @@ The result files use standard XUnitPerformanceHarness formatting. Typical metric
MusicStore/First Request Duration ms 2 872 24.04163056 855 889
MusicStore/Median Response Duration ms 2 88.8 0 88.8 88.8
MusicStore/Startup Duration ms 2 887 35.35533906 862 912

## Why is this project in a folder marked 'unofficial'?

CoreCLR CI machines don't currently support building netcoreapp2.0 projects authored with the new msbuild SDK authoring style so the repo build uses the JitBench.csproj one directory higher, not the one in this directory. If you try to build the project in this directory in CI you get this error:

C:\Program Files\dotnet\sdk\1.1.0\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.TargetFrameworkInference.targets(112,5): error : The current .NET SDK does not support targeting .NET Core 2.0. Either target .NET Core 1.1 or lower, or use a version of the .NET SDK that supports .NET Core 2.0. [D:\j\workspace\x64_checked_w---eac6a79c\tests\src\performance\Scenario\JitBench\JitBench.csproj]

I assume the CI machines have fairly old SDK tools installed but I didn't have enough time to keep investigating these build issues. From I can tell if you have .NET Core 2.0+ SDK installed on your machine this build works fine from the command line and from VS.

0 comments on commit 2ce073a

Please sign in to comment.