Add deflate_make_dht() to the Develop branch #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bulent Abali <[email protected]>
hzhuang1
pushed a commit
to Linaro/warpdrive-zlib
that referenced
this pull request
Jul 31, 2019
Merge Hacknslash7
jinfeihan57
pushed a commit
to minchai23/zlib
that referenced
this pull request
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to add the deflate_make_dht() function to deflate.c in the develop branch.
Caller supplies histograms of Literal/Length and Distance symbols.
The function creates a dynamic huffman table that deflate() would have inserted in a type 2 block.
A working example is found in examples/makedht.c that I based off of examples/zpipe.c.
Why do we need this new function?
If you are a student of zlib, OR when you are debugging your own inflate implementation, e.g. implemented in software or hardware, and you want to test it with various huffman tables that zlib would have produced. Few more details in the wiki https://github.com/abalib/zlib/wiki