fix(types): Remove unused Loader.loader property.

madmod · Apr 1, 2021 · fb1ead0 · fb1ead0
1 parent f20e155
commit fb1ead0
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 8 deletions.
diff --git a/api-extractor/report/hls.js.api.md b/api-extractor/report/hls.js.api.md
@@ -1560,8 +1560,6 @@ export interface Loader<T extends LoaderContext> {
     // (undocumented)
     load(context: LoaderContext, config: LoaderConfiguration, callbacks: LoaderCallbacks<T>): void;
     // (undocumented)
-    loader: any;
-    // (undocumented)
     stats: LoaderStats;
 }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/types/loader.ts b/src/types/loader.ts
@@ -122,7 +122,6 @@ export interface Loader<T extends LoaderContext> {
   ): void;
   getResponseHeader(name: string): string | null;
   context: T;
-  loader: any;
   stats: LoaderStats;
 }
 

diff --git a/src/utils/fetch-loader.ts b/src/utils/fetch-loader.ts
@@ -37,7 +37,7 @@ class FetchLoader implements Loader<LoaderContext> {
   private config: LoaderConfiguration | null = null;
   private callbacks: LoaderCallbacks<LoaderContext> | null = null;
   public stats: LoaderStats;
-  public loader: Response | null = null;
+  private loader: Response | null = null;
 
   constructor(config /* HlsConfig */) {
     this.fetchSetup = config.fetchSetup || getRequest;

diff --git a/src/utils/xhr-loader.ts b/src/utils/xhr-loader.ts
@@ -17,7 +17,7 @@ class XhrLoader implements Loader<LoaderContext> {
   private callbacks: LoaderCallbacks<LoaderContext> | null = null;
   public context!: LoaderContext;
 
-  public loader: XMLHttpRequest | null = null;
+  private loader: XMLHttpRequest | null = null;
   public stats: LoaderStats;
 
   constructor(config /* HlsConfig */) {

diff --git a/tests/unit/loader/fragment-loader.ts b/tests/unit/loader/fragment-loader.ts
@@ -22,7 +22,6 @@ const expect = chai.expect;
 
 class MockXhr implements Loader<LoaderContext> {
   context!: LoaderContext;
-  loader: any;
   stats: LoadStats;
   callbacks?: LoaderCallbacks<FragmentLoaderContext>;