use sizeof instead of strlen to get the shellcode size

magebeans · Jul 30, 2013 · 7b5ff07 · 7b5ff07
1 parent 11af2fc
commit 7b5ff07
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/shellnoob.py b/shellnoob.py
@@ -156,9 +156,9 @@ class ShellNoob():
 
 int main() {
     // make sure the memory is RWX to support self-modifying shellcode
-    char *target = (char *) memalign(4096, strlen(shellcode));
-    mprotect(target, strlen(shellcode), PROT_READ | PROT_WRITE | PROT_EXEC);
-    memcpy(target, shellcode, strlen(shellcode));
+    char *target = (char *) memalign(4096, sizeof(shellcode));
+    mprotect(target, sizeof(shellcode), PROT_READ | PROT_WRITE | PROT_EXEC);
+    memcpy(target, shellcode, sizeof(shellcode));
     (*(void (*)()) target)();
     return 0;
 }