Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] Implement 4x Equipment-related cards #12593

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Conversation

ssk97
Copy link
Contributor

@ssk97 ssk97 commented Jul 20, 2024

Implements 4 cards, either equipment or equipment-matters cards. Also fixes a few mistakes in other ACR cards' implementations and fixes text generation for DamageTargetControllerEffect.

@ssk97
Copy link
Contributor Author

ssk97 commented Jul 21, 2024

This test failure is unrelated to these changes - it appears to be a problem with test_TokenExists_CopyEffectMustRestoreOldImageAfterEnd where it creates both islands and plains (inside prepareCards_TheHive) and then can sometimes tap all of the islands first leaving it unable to cast Echoing Equation.

@xenohedron xenohedron merged commit 3933364 into magefree:master Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants