Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable configuring the measurement base distance is measured in #304

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Enable configuring the measurement base distance is measured in #304

merged 1 commit into from
Jun 24, 2019

Conversation

dg9vh
Copy link
Contributor

@dg9vh dg9vh commented Jun 24, 2019

In reference to #303 this would be the solution.

magicbug
magicbug approved these changes Jun 24, 2019
View reviewed changes
Copy link
Owner

@magicbug magicbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sure people will appreciate this being configurable

@magicbug magicbug merged commit 0b9767c into magicbug:master Jun 24, 2019
@dg9vh dg9vh deleted the measurements branch June 24, 2019 14:08
@dg9vh
Copy link
Contributor Author

dg9vh commented Jun 24, 2019

Well, yes. I think many continental-europeans would like to use ISO-units like kilometer for distance :-)

TNX fer merge

@magicbug
Copy link
Owner

Everyone should use miles (says the person from the uk)

@dg9vh
Copy link
Contributor Author

dg9vh commented Jun 24, 2019

;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicbug magicbug magicbug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dg9vh @magicbug