Skip to content

Commit

Permalink
chore: Update suggestion type docs to mention not adding interactive …
Browse files Browse the repository at this point in the history
…elements to the footer (microsoft#26165)

* Update comments on suggestion footer render to mention that it should not include interactive elements

* change file

* Apply suggestions from code review

Co-authored-by: Makoto Morimoto <[email protected]>

Co-authored-by: Makoto Morimoto <[email protected]>
  • Loading branch information
micahgodbolt and khmakoto authored Jan 5, 2023
1 parent fef0e43 commit 92c695c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Suggestions: change resultsFooter docs to mention not adding interactive elements",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,13 @@ export interface ISuggestionsProps<T> extends IReactProps<any> {

/**
* A renderer that adds an element at the end of the suggestions list it has more items than resultsMaximumNumber.
* This should not include interactive elements as the footer is not focusable.
*/
resultsFooterFull?: (props: ISuggestionsProps<T>) => JSX.Element;

/**
* A renderer that adds an element at the end of the suggestions list it has fewer items than resultsMaximumNumber.
* This should not include interactive elements as the footer is not focusable.
*/
resultsFooter?: (props: ISuggestionsProps<T>) => JSX.Element;

Expand Down

0 comments on commit 92c695c

Please sign in to comment.