Skip to content

Commit

Permalink
lib/kstrtox.c: delete unnecessary casts
Browse files Browse the repository at this point in the history
Implicit casts to the same type are done by the language if necessary.

Link: http://lkml.kernel.org/r/20181014223934.GA18107@avx2
Signed-off-by: Alexey Dobriyan <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Alexey Dobriyan authored and torvalds committed Oct 31, 2018
1 parent 7e5ca36 commit 048e513
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions lib/kstrtox.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ int _kstrtoul(const char *s, unsigned int base, unsigned long *res)
rv = kstrtoull(s, base, &tmp);
if (rv < 0)
return rv;
if (tmp != (unsigned long long)(unsigned long)tmp)
if (tmp != (unsigned long)tmp)
return -ERANGE;
*res = tmp;
return 0;
Expand All @@ -191,7 +191,7 @@ int _kstrtol(const char *s, unsigned int base, long *res)
rv = kstrtoll(s, base, &tmp);
if (rv < 0)
return rv;
if (tmp != (long long)(long)tmp)
if (tmp != (long)tmp)
return -ERANGE;
*res = tmp;
return 0;
Expand Down Expand Up @@ -222,7 +222,7 @@ int kstrtouint(const char *s, unsigned int base, unsigned int *res)
rv = kstrtoull(s, base, &tmp);
if (rv < 0)
return rv;
if (tmp != (unsigned long long)(unsigned int)tmp)
if (tmp != (unsigned int)tmp)
return -ERANGE;
*res = tmp;
return 0;
Expand Down Expand Up @@ -253,7 +253,7 @@ int kstrtoint(const char *s, unsigned int base, int *res)
rv = kstrtoll(s, base, &tmp);
if (rv < 0)
return rv;
if (tmp != (long long)(int)tmp)
if (tmp != (int)tmp)
return -ERANGE;
*res = tmp;
return 0;
Expand All @@ -268,7 +268,7 @@ int kstrtou16(const char *s, unsigned int base, u16 *res)
rv = kstrtoull(s, base, &tmp);
if (rv < 0)
return rv;
if (tmp != (unsigned long long)(u16)tmp)
if (tmp != (u16)tmp)
return -ERANGE;
*res = tmp;
return 0;
Expand All @@ -283,7 +283,7 @@ int kstrtos16(const char *s, unsigned int base, s16 *res)
rv = kstrtoll(s, base, &tmp);
if (rv < 0)
return rv;
if (tmp != (long long)(s16)tmp)
if (tmp != (s16)tmp)
return -ERANGE;
*res = tmp;
return 0;
Expand All @@ -298,7 +298,7 @@ int kstrtou8(const char *s, unsigned int base, u8 *res)
rv = kstrtoull(s, base, &tmp);
if (rv < 0)
return rv;
if (tmp != (unsigned long long)(u8)tmp)
if (tmp != (u8)tmp)
return -ERANGE;
*res = tmp;
return 0;
Expand All @@ -313,7 +313,7 @@ int kstrtos8(const char *s, unsigned int base, s8 *res)
rv = kstrtoll(s, base, &tmp);
if (rv < 0)
return rv;
if (tmp != (long long)(s8)tmp)
if (tmp != (s8)tmp)
return -ERANGE;
*res = tmp;
return 0;
Expand Down

0 comments on commit 048e513

Please sign in to comment.