Skip to content

Commit

Permalink
mm/migrate: Convert expected_page_refs() to folio_expected_refs()
Browse files Browse the repository at this point in the history
Now that both callers have a folio, convert this function to
take a folio & rename it.

Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
  • Loading branch information
Matthew Wilcox (Oracle) committed Aug 2, 2022
1 parent 6723518 commit 108ca83
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions mm/migrate.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,13 +336,18 @@ void pmd_migration_entry_wait(struct mm_struct *mm, pmd_t *pmd)
}
#endif

static int expected_page_refs(struct address_space *mapping, struct page *page)
static int folio_expected_refs(struct address_space *mapping,
struct folio *folio)
{
int expected_count = 1;
int refs = 1;
if (!mapping)
return refs;

if (mapping)
expected_count += compound_nr(page) + page_has_private(page);
return expected_count;
refs += folio_nr_pages(folio);
if (folio_test_private(folio))
refs++;

return refs;
}

/*
Expand All @@ -359,7 +364,7 @@ int folio_migrate_mapping(struct address_space *mapping,
XA_STATE(xas, &mapping->i_pages, folio_index(folio));
struct zone *oldzone, *newzone;
int dirty;
int expected_count = expected_page_refs(mapping, &folio->page) + extra_count;
int expected_count = folio_expected_refs(mapping, folio) + extra_count;
long nr = folio_nr_pages(folio);

if (!mapping) {
Expand Down Expand Up @@ -669,7 +674,7 @@ static int __buffer_migrate_folio(struct address_space *mapping,
return migrate_page(mapping, &dst->page, &src->page, mode);

/* Check whether page does not have extra refs before we do more work */
expected_count = expected_page_refs(mapping, &src->page);
expected_count = folio_expected_refs(mapping, src);
if (folio_ref_count(src) != expected_count)
return -EAGAIN;

Expand Down

0 comments on commit 108ca83

Please sign in to comment.