Skip to content

Commit

Permalink
seq_buf: Use size_t for len in seq_buf_puts()
Browse files Browse the repository at this point in the history
Jann Horn points out that we're using unsigned int for len in
seq_buf_puts(), which could potentially overflow if we're passed a
UINT_MAX sized string.

The rest of the code already uses size_t, so we should also use that
in seq_buf_puts() to avoid any issues.

Link: http://lkml.kernel.org/r/[email protected]

Suggested-by: Jann Horn <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
  • Loading branch information
mpe authored and rostedt committed Dec 22, 2018
1 parent 0464ed2 commit 29924e5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/seq_buf.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ int seq_buf_bprintf(struct seq_buf *s, const char *fmt, const u32 *binary)
*/
int seq_buf_puts(struct seq_buf *s, const char *str)
{
unsigned int len = strlen(str);
size_t len = strlen(str);

WARN_ON(s->size == 0);

Expand Down

0 comments on commit 29924e5

Please sign in to comment.