Skip to content

Commit

Permalink
parisc: remove arch/parisc/nm
Browse files Browse the repository at this point in the history 
Parisc overrides 'nm' with a shell script. I was hit by a false-positive
error of $(NM) because this script returns the exit status of grep
instead of ${CROSS_COMPILE}nm. (grep returns 1 if no lines were selected)

I tried to fix it, but in the code review, Helge suggested to remove it
entirely. [1]

This script was added in 2003. [2]

Presumably, it was a workaround for old toolchains (but even the parisc
maintainer does not know the detail any more).

Hopefully, recent tools should work fine.

[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=36eaa6e4c0e0b6950136b956b72fd08155b92ca3

Suggested-by: Helge Deller <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
Acked-by: Helge Deller <[email protected]>
  • Loading branch information
@masahir0y
masahir0y committed May 29, 2022
1 parent c25e1c5 commit 534671e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion arch/parisc/Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
boot := arch/parisc/boot
KBUILD_IMAGE := $(boot)/bzImage

NM = sh $(srctree)/arch/parisc/nm
CHECKFLAGS += -D__hppa__=1

ifdef CONFIG_64BIT
Expand Down
6 changes: 0 additions & 6 deletions arch/parisc/nm
View file

This file was deleted.

0 comments on commit 534671e

Please sign in to comment.